Falco version and driver version are not coupled anymore #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e correct FALCO_VERSION env variable Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
… have exact FALCO_VERSION env variable This avoids `FALCO_VERSION` variable to be equal to `latest` while `falco --version` correctly returns 0.21.0 Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
…sion Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
…inghuishes driver version from falco version Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
|
/cc @fntlnz |
fntlnz
reviewed
Mar 23, 2020
fntlnz
previously approved these changes
Mar 23, 2020
|
LGTM label has been added. Git tree hash: 85e68d8a97229ab5431c158007d0c16a92773630
|
Signed-off-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Closed
|
/cc @kris-nova |
krisnova
reviewed
Mar 23, 2020
krisnova
reviewed
Mar 23, 2020
krisnova
approved these changes
Mar 23, 2020
|
LGTM label has been added. Git tree hash: 2faf64b02d684c0d410cfac3352838e81721c1ff
|
fntlnz
approved these changes
Mar 23, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, kris-nova The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
Any specific area of the project related to this PR?
/area build
/area tests
What this PR does / why we need it:
This PR introduces some fixes and updates needed because the Falco version and the driver version are distinct values now.
So this PR mainly updates the
falco-probe-loaderscript for this reason. Also renaming it tofalco-driver-loader.Futhermore, this script obtains now some values (like the
DRIVER_VERSIONvariable value) at configuration time.Finally it also ensures that the
FALCO_VERSIONenv variable inside docker containers contains the same value returned byfalco --version, not the docker image tag.Which issue(s) this PR fixes:
Fixes #1107
Fixes #1110
Special notes for your reviewer:
Does this PR introduce a user-facing change?: