refactor(locale): fix truncated song names with commas #3327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
likely accidentally lost when originally imported ref faker-js#996 and https://manghammath.com/80s%20Hits/The%20Top%201000%20Songs%20of%20AllTime.pdf
matthewmayer
added
c: locale
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3327 +/- ##
==========================================
- Coverage 99.97% 99.96% -0.01%
==========================================
Files 2806 2806
Lines 217086 217086
Branches 975 966 -9
==========================================
- Hits 217032 217012 -20
- Misses 54 74 +20
|
ST-DDT
approved these changes
Dec 5, 2024
ST-DDT
changed the title
yep, its mostly just slight renames so didn't affect the snapshotted values |
xDivisionByZerox
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
likely accidentally lost when originally imported
ref #996 and https://manghammath.com/80s%20Hits/The%20Top%201000%20Songs%20of%20AllTime.pdf