Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proppy-preact: Fix for passing children #22

Merged
merged 1 commit into from
Jul 18, 2018
Merged

proppy-preact: Fix for passing children #22

merged 1 commit into from
Jul 18, 2018

Conversation

jchn
Copy link
Contributor

@jchn jchn commented Jul 18, 2018

Fix for #21

@fahad19 fahad19 changed the title Pass props.children proppy-preact: Fix for passing children Jul 18, 2018
@fahad19 fahad19 merged commit 4c5623f into fahad19:master Jul 18, 2018
@fahad19 fahad19 mentioned this pull request Jul 18, 2018
Closed
@fahad19
Copy link
Owner

fahad19 commented Jul 18, 2018 •
edited
Loading

Thank you very much, @jchn! 🎉

I will be releasing a new patch version in a few minutes with your fix.

@fahad19
Copy link
Owner

fahad19 commented Jul 18, 2018

Done: https://github.com/fahad19/proppy/releases/tag/v1.2.3

@jchn
Copy link
Contributor Author

jchn commented Jul 18, 2018

Wow that was fast! Thanks for this great library! 😄

@fahad19 fahad19 mentioned this pull request Jul 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
patch PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jchn @fahad19