Skip to content
This repository has been archived by the owner on Sep 3, 2024. It is now read-only.

Core: No error thrown when component is defined but not added to the component list #21

Closed
ruben-iteng opened this issue Dec 17, 2021 · 0 comments · Fixed by #26
Closed

Core: No error thrown when component is defined but not added to the component list #21

ruben-iteng opened this issue Dec 17, 2021 · 0 comments · Fixed by #26

Comments

@ruben-iteng
Copy link
Collaborator

This will not throw a Faebryk error, but give a KeyError when rendering the netlist with matplotlib

gnd = VirtualComponent(...)
vcc= VirtualComponent(...)
resistor = SMD_Resistor(..)

resistor.connect(1, vcc)
resistor.connect(2, gnd)

comps = [gnd, resistor]
    netlist = from_faebryk_t2_netlist(
        make_t2_netlist_from_t1(
            make_t1_netlist_from_graph(comps)
        )
    )
@IoannisP-ITENG IoannisP-ITENG mentioned this issue Dec 17, 2021
Merged
IoannisP-ITENG added a commit that referenced this issue Dec 17, 2021
@IoannisP-ITENG
Core: Throw error if graph edge to an unkown node (#26)
9d0b2c2 
Fixes #21
IoannisP-ITENG pushed a commit that referenced this issue Sep 2, 2024
@ruben-iteng
Libs: KiCad: fileformats update footprint (#21)
60856b7 
* Add: global text_layer class

* Fix: keepout bool

* Add: offset and other options to pad class
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Core: Throw error if graph edge to an unkown node faebryk/faebryk
1 participant
@ruben-iteng