This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
Rework the tests to make sure that all GPU tests are ran and that skipped tests do not trigger warnings upon integration #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D29557107 |
QuentinDuval
added a commit
to QuentinDuval/vissl
that referenced
this pull request
Jul 6, 2021
…pped tests do not trigger warnings upon integration (facebookresearch#356) Summary: Pull Request resolved: facebookresearch#356 Two main changes: - Make sure that all GPU tests are run on CircleCI - Make sure that skipped GPU tests do not trigger warnings This required to split the test_losses in part and update some other tests as well. Differential Revision: D29557107 fbshipit-source-id: 9438227fe585d282d1fd4561dbe7671eabc2374e
QuentinDuval
force-pushed
the
export-D29557107
branch
from
fb39204 to
401c0f1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D29557107 |
QuentinDuval
added a commit
to QuentinDuval/vissl
that referenced
this pull request
Jul 6, 2021
…pped tests do not trigger warnings upon integration (facebookresearch#356) Summary: Pull Request resolved: facebookresearch#356 Two main changes: - Make sure that all GPU tests are run on CircleCI - Make sure that skipped GPU tests do not trigger warnings This required to split the test_losses in part and update some other tests as well. Differential Revision: D29557107 fbshipit-source-id: 4a1cc595198dea9b167cca9363f0ac449f9e1a09
QuentinDuval
force-pushed
the
export-D29557107
branch
from
401c0f1 to
86611d9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D29557107 |
QuentinDuval
added a commit
to QuentinDuval/vissl
that referenced
this pull request
Jul 7, 2021
…pped tests do not trigger warnings upon integration (facebookresearch#356) Summary: Pull Request resolved: facebookresearch#356 Two main changes: - Make sure that all GPU tests are run on CircleCI - Make sure that skipped GPU tests do not trigger warnings This required to split the test_losses in part and update some other tests as well. Differential Revision: D29557107 fbshipit-source-id: de1743c823499b8e4366fd05c3432cf389f40a12
|
This pull request was exported from Phabricator. Differential Revision: D29557107 |
QuentinDuval
force-pushed
the
export-D29557107
branch
from
86611d9 to
1f42aa7
Compare
QuentinDuval
added a commit
to QuentinDuval/vissl
that referenced
this pull request
Jul 7, 2021
…pped tests do not trigger warnings upon integration (facebookresearch#356) Summary: Pull Request resolved: facebookresearch#356 Two main changes: - Make sure that all GPU tests are run on CircleCI - Make sure that skipped GPU tests do not trigger warnings This required to split the test_losses in part and update some other tests as well. Differential Revision: D29557107 fbshipit-source-id: cbba56249419e9d95b37563e827930d7ef0669d9
QuentinDuval
force-pushed
the
export-D29557107
branch
from
1f42aa7 to
cef2afb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D29557107 |
…pped tests do not trigger warnings upon integration (facebookresearch#356) Summary: Pull Request resolved: facebookresearch#356 Two main changes: - Make sure that all GPU tests are run on CircleCI - Make sure that skipped GPU tests do not trigger warnings This required to split the test_losses in part and update some other tests as well. Differential Revision: D29557107 fbshipit-source-id: 1622bc0fb8512c895d9dffc77bc6237c5f1d95f1
|
This pull request was exported from Phabricator. Differential Revision: D29557107 |
QuentinDuval
force-pushed
the
export-D29557107
branch
from
cef2afb to
9d45532
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 8, 2021
…pped tests do not trigger warnings upon integration (#356) Summary: Pull Request resolved: #356 Two main changes: - Make sure that all GPU tests are run on CircleCI - Make sure that skipped GPU tests do not trigger warnings This required to split the test_losses in part and update some other tests as well. Reviewed By: prigoyal Differential Revision: D29557107 fbshipit-source-id: a46823097983d0b58bc6d20bab5fef03820dd07d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Two main changes:
This required to split the test_losses in part and update some other tests as well.
Differential Revision: D29557107