-
Notifications
You must be signed in to change notification settings - Fork 334
Installation instructions for VISSL in source mode (dev should be surrounded by quotes) #224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@QuentinDuval has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, small inline curious comment :)
let's also update the docs/installation.rst file to reflect this change.
…reflect the chances on the README
@QuentinDuval has updated the pull request. You must reimport the pull request before landing. |
Indeed, I keep forgetting the docs ! It should be fixed following f08d2fa. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@QuentinDuval has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@QuentinDuval merged this pull request in 8d6789a. |
…224) Summary: DDP is needed for SyncBN to work on the teacher side. Added tests on DINO to catch any further regression. X-link: fairinternal/ssl_scaling#224 Reviewed By: prigoyal Differential Revision: D34590006 Pulled By: QuentinDuval fbshipit-source-id: 98d7195418024615aff3ac2923b7a833940eac91
No description provided.