Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Installation instructions for VISSL in source mode (dev should be surrounded by quotes) #224

Closed

Conversation

QuentinDuval
Copy link
Contributor

No description provided.

@QuentinDuval QuentinDuval requested a review from prigoyal March 9, 2021 13:59
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 9, 2021
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QuentinDuval has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@prigoyal prigoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, small inline curious comment :)

let's also update the docs/installation.rst file to reflect this change.

INSTALL.md Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@QuentinDuval has updated the pull request. You must reimport the pull request before landing.

@QuentinDuval
Copy link
Contributor Author

looks great, small inline curious comment :)

let's also update the docs/installation.rst file to reflect this change.

Indeed, I keep forgetting the docs !

It should be fixed following f08d2fa.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QuentinDuval has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@QuentinDuval merged this pull request in 8d6789a.

facebook-github-bot pushed a commit that referenced this pull request Mar 11, 2022
…224)

Summary:
DDP is needed for SyncBN to work on the teacher side. Added tests on DINO to catch any further regression.

X-link: fairinternal/ssl_scaling#224

Reviewed By: prigoyal

Differential Revision: D34590006

Pulled By: QuentinDuval

fbshipit-source-id: 98d7195418024615aff3ac2923b7a833940eac91
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants