This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
Refactor distributed_launcher logic and simplify fb build #185
+397
−397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he right amount of resources (facebookresearch#184) Summary: Improve the submission of distributed training on SLURM (rebase of previous PR facebookresearch#144): - use the configuration of the experiment to deduce the number of nodes and GPUs to allocate on SLURM: the user does not have to specify it manually, avoiding potential mistakes - move SLURM config from bash to standard VISSL YAML config, allowing SLURM options (like the options of VISSL) to be configured with hydra overrides - use Python submitit library instead of bash to start SLURM jobs: a prerequisite to deal with the points above, moving to Python is what allows to read the hydra VISSL configuration to start the SLURM jobs Pull Request resolved: facebookresearch#184 Differential Revision: D26353975 Pulled By: QuentinDuval fbshipit-source-id: 685c0346e437a8a1fd4e855086ad6639205810ea
Summary: we are bringing in submitit to VISSL (thanks to QuentinDuval ) and this required moving the `launch_distributed` to the core `vissl` library. Some refactorings needed to make the fblearner workflow adapt accordingly. Differential Revision: D26340992 fbshipit-source-id: 077594ff2698c6d07a1ca3c2c75b8a87ca74d1a5
|
This pull request was exported from Phabricator. Differential Revision: D26340992 |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D26340992 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D26340992 |
|
This pull request has been merged in e94858c. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: we are bringing in submitit to VISSL (thanks to QuentinDuval ) and this required moving the
launch_distributedto the corevissllibrary. Some refactorings needed to make the fblearner workflow adapt accordingly.Differential Revision: D26340992