This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
Make fairscale not a hard dependecy and more robust imports #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D26102068 fbshipit-source-id: 52575b44df09dd83c1c74ffecd5d1318fcda4e1f
Differential Revision: D26147504 fbshipit-source-id: 5db2d7e9157d6c567ef778c0dd2083848a0069b7
Summary: while packaging vissl, we observed that fairscale didn't have latest conda packages. The only hard dependency on fairscale is using ShardedGradScalar. We move this import to inline where it's actually used and add asserts :) this helps to make fairscale not a hard dependency for vissl especially if some users may not want to do scaling in vissl Reviewed By: min-xu-ai Differential Revision: D26230353 fbshipit-source-id: dc45adcac6cfde80f471dc3bd9341bb53b847a7f
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D26230353 |
|
This pull request has been merged in a68220f. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 19, 2021
…usion (#172) Summary: Pull Request resolved: fairinternal/ssl_scaling#172 Reviewed By: iseessel Differential Revision: D29767202 Pulled By: QuentinDuval fbshipit-source-id: 60a36921963776bb5b25f9391af15c4c884d764f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: while packaging vissl, we observed that fairscale didn't have latest conda packages. The only hard dependency on fairscale is using ShardedGradScalar. We move this import to inline where it's actually used and add asserts :) this helps to make fairscale not a hard dependency for vissl especially if some users may not want to do scaling in vissl
Reviewed By: min-xu-ai
Differential Revision: D26230353