Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Updating the getting started and docs to be more verbose #167

Closed
wants to merge 7 commits into from

Conversation

prigoyal
Copy link
Contributor

@prigoyal prigoyal commented Feb 3, 2021

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 3, 2021
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prigoyal has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@prigoyal has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@prigoyal has updated the pull request. You must reimport the pull request before landing.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prigoyal has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@prigoyal has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@prigoyal has updated the pull request. You must reimport the pull request before landing.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prigoyal has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@prigoyal merged this pull request in c1664c9.

@prigoyal prigoyal deleted the getting-started-docs-update branch February 3, 2021 18:15
facebook-github-bot pushed a commit that referenced this pull request Jul 15, 2021
Summary:
## Label smoothing made easier in VISSL

Before this PR, the only way to make it work would be to modify the `labels.py` files or to use the `cutmixup` collator. In some instances, this is rather impractical.

This PR allows to have the label smoothing done by just setting a flag in the loss like this:

```
  LOSS:
    name: cross_entropy_multiple_output_single_target
    cross_entropy_multiple_output_single_target:
      ignore_index: -1
      label_smoothing: 0.1
```

I also refactored the code a bit:
- added unit tests on the surrounding code
- extracted the criterion from the configuration (allowing to have non framework dependent components)

Pull Request resolved: fairinternal/ssl_scaling#167

Reviewed By: prigoyal

Differential Revision: D29639909

Pulled By: QuentinDuval

fbshipit-source-id: f8348cc801ee7f726b07424342fc8aed74a361c9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants