[FLAVA]Upgrade lightning and pillow dependencies #396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov ReportBase: 63.52% // Head: 63.52% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
=======================================
Coverage 63.52% 63.52%
=======================================
Files 143 143
Lines 9605 9605
=======================================
Hits 6102 6102
Misses 3503 3503 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@ankitade has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ebsmothers
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
flava broke as pytorch nightly became incompatible with lightning 1.6 due to pytorch/pytorch@0a69c50. upgrade to 1.8.6 and remove progress_bar_refresh_rate which was removed in lightning later versions
upgrade pillow to fix https://github.com/facebookresearch/multimodal/security/dependabot/3
Test plan:
python -m flava.train config=flava/configs/pretraining/debug.yaml training.lightning.accelerator=cpu training.lightning.gpus=0 training.lightning.strategy=null
Epoch 0: : 116it [08:45, 4.53s/it, loss=13.4, v_num=14, train/losses/mim_loss=9.150, train/losses/mlm_loss=9.310, train/losses/mmm_text_loss=8.370, train/losses/mmm_image_loss=9.070, train/losses/itm_loss=0.668, train/losses/global_contrastive_loss=2.090]