Refactored tensor equal assertion test into common utility #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
langong347
reviewed
May 10, 2022
langong347
approved these changes
May 10, 2022
|
@RdoubleA has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
suiyoubi
added a commit
to suiyoubi/multimodal
that referenced
this pull request
May 11, 2022
* Change ImageDataModule to the old style such as we don't need to extract it. Fixed minor bugs. * add lightning logs to gitignore * change config file for imagenet directory * add transformer denpendency * add SAVE_DIR * Add default for imagent_tar * Refactored tensor equal assertion test into common utility (facebookresearch#39) Summary: The use of `torch.testing.assert_close(actual, expected)` was a prevalent pattern throughout the codebase, each having to create its own assertion failure message. This was consolidated into a common utility function in `test/test_utils.py` such that this assertion is only defined in a single location and all current/future unit tests simply have to import this to test if two tensors are equal without having to write the same assertion failure message. Pull Request resolved: facebookresearch#39 Test Plan: Since this impacts potentially all unit tests, I ran the entire test suite with `pytest -vv`. Reviewed By: langong347 Differential Revision: D36301056 Pulled By: RdoubleA fbshipit-source-id: 0e0f62717186efa1307f545ac1bbe82ffed65a58 * quick fix for zero-shot validation * Add num_nodes in training conf Co-authored-by: aot <aot@nvidia.com> Co-authored-by: Rafi Ayub <rafiayub@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The use of
torch.testing.assert_close(actual, expected)was a prevalent pattern throughout the codebase, each having to create its own assertion failure message. This was consolidated into a common utility function intest/test_utils.pysuch that this assertion is only defined in a single location and all current/future unit tests simply have to import this to test if two tensors are equal without having to write the same assertion failure message.Test plan:
Since this impacts potentially all unit tests, I ran the entire test suite with
pytest -vv.