Run unit tests for python 3.9 also #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@ankitade has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
langong347
approved these changes
May 9, 2022
|
@ankitade has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
langong347
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Check python 3.9 also for tests. This should cover the basic build from source testing as a side effect also. Nice thing, it runs the 2 flows in parallel :)
Test plan:
Unit test gha on this PR itself
https://github.com/facebookresearch/multimodal/actions/runs/2287274575
The mypy one is failing for unrelated reasons, Lan has a fix out