Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade HF Datasets Library for Flava Example #362

Closed
wants to merge 3 commits into from
Closed

Upgrade HF Datasets Library for Flava Example #362

wants to merge 3 commits into from

Conversation

pbontrager
Copy link
Contributor

Summary:
Updated Hugging Face datasets library version in examples/flava. The older version can no longer interface with the HF online API and therefore cannot pull requested datasets.

Test plan:
I created a new conda env and built the dependencies using the new requirement. From there I ran the flava train.py script where it successfully pulled the Imagenet dataset as it's supposed to do and successfully started training.

@pbontrager pbontrager requested a review from ankitade October 26, 2022 14:47
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 26, 2022
@ankitade ankitade requested a review from apsdehal October 26, 2022 18:02
apsdehal
apsdehal approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@apsdehal apsdehal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but looks like tests are breaking unless they were failing before as well.

@pbontrager
Copy link
Contributor Author

LGTM but looks like tests are breaking unless they were failing before as well.

TorchText Nightly isn't building which is breaking the tests. I'll push again after that is resolved.

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022 •
edited
Loading

Codecov Report

Base: 93.43% // Head: 93.43% // No change to project coverage 👍

Coverage data is based on head (3ee1eee) compared to base (3764027).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #362   +/-   ##
=======================================
  Coverage   93.43%   93.43%           
=======================================
  Files          55       55           
  Lines        3262     3262           
=======================================
  Hits         3048     3048           
  Misses        214      214

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@facebook-github-bot
Copy link
Contributor

@pbontrager has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@pbontrager has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@ankitade ankitade deleted the flava_update_reqs branch January 30, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitade ankitade ankitade approved these changes

@apsdehal apsdehal apsdehal approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pbontrager @codecov-commenter @facebook-github-bot @apsdehal @ankitade