Fix warnings thrown during testing: FLAVA, SamePadConv (#325) #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rch#325) Summary: Pull Request resolved: facebookresearch#325 Fixed the following warnings: ``` test/models/flava/test_checkpoint.py::TestFLAVACheckpoint::test_flava_model_for_pretraining /data/home/langong/repos/ci/test/models/flava/test_checkpoint.py:105: UserWarning: To copy construct from a tensor, it is recommended to use sourceTensor.clone().detach() or sourceTensor.clone().detach().requires_grad_(True), rather than torch.tensor(sourceTensor). else torch.tensor(dict_actual[key]) test/modules/layers/test_conv.py::TestSamePadConv3d::test_samepadconv3d_forward /data/home/langong/repos/ci/torchmultimodal/modules/layers/conv.py:49: UserWarning: Padding was specified but will not be used in favor of same padding, use Conv3d directly for custom padding warnings.warn( ``` Add ignore to `pooling_function` of `mil_encoder.py` to suppress `mypy` error: ``` torchmultimodal/modules/encoders/mil_encoder.py:73:30: error: Argument Installing missing stub packages: /usr/share/miniconda3/envs/test/bin/python -m pip install types-setuptools types-tabulate Found 1 error in 1 file (checked 59 source files) "pooling_function" has incompatible type "Callable[..., Any]"; expected "TransformerEncoder" [arg-type] pooling_function=pooling_function, ^~~~~~~~~~~~~~~~ ``` Test Plan: - `python -m pytest test/modules/layers/test_conv.py` - `python -m pytest test/models/flava/test_checkpoint.py` Reviewed By: pikapecan Differential Revision: D39833572 Pulled By: langong347 fbshipit-source-id: 8e1647d65f25885e141541b4d2ef755f269a1fcc
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D39833572 |
Codecov ReportBase: 93.63% // Head: 93.63% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
=======================================
Coverage 93.63% 93.63%
=======================================
Files 54 54
Lines 3238 3238
=======================================
Hits 3032 3032
Misses 206 206
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pull Request resolved: #325
Fixed the following warnings:
Add ignore to
pooling_functionofmil_encoder.pyto suppressmypyerror:Test Plan:
python -m pytest test/modules/layers/test_conv.pypython -m pytest test/models/flava/test_checkpoint.pyReviewed By: pikapecan
Differential Revision: D39833572
Pulled By: langong347