Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] - remove outdated functions from C++ simulator #2498

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Nov 12, 2024

Motivation and Context

Removes a few outdated things from C++ Simulator:

  • setObjectBBDraw and python set_object_bb_draw - removed because debug line rendering is the preferred method for this kind of feature, not a Simulator API
  • saveFrame - not implemented
  • queryArticulatedObjWrapper - outdated, use the manager

How Has This Been Tested

CI should pass (maybe not lab) see facebookresearch/habitat-lab#2106

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested a review from jturner65 November 12, 2024 21:42
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 12, 2024
@aclegg3 aclegg3 merged commit dc6c76a into main Nov 13, 2024
9 checks passed
@aclegg3 aclegg3 deleted the alex-11_12-cleanup_sim branch November 13, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants