Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--[BE] - Save ref to object's ManagedObject wrapper for internal access. #2496

Merged
merged 2 commits into from
Nov 13, 2024
Merged

--[BE] - Save ref to object's ManagedObject wrapper for internal access. #2496

merged 2 commits into from
Nov 13, 2024

Conversation

jturner65
Copy link
Contributor

This PR adds a pointer to each Rigid and Articulated Object to the Managed Object containing it. This is for python-driven internal access, so that, for instance, an articulated link can return a ManagedArticulatedObject reference to the AO it is a part of.

TODO : add tests for functionality

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 requested a review from aclegg3 November 11, 2024 21:25
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 11, 2024
@jturner65 jturner65 force-pushed the BE_InternalAccessToObjWrappers branch from 243331b to cad98c3 Compare November 12, 2024 14:26
@jturner65 jturner65 changed the title --[BE][WIP] - Save ref to object's ManagedObject wrapper for internal access. --[BE] - Save ref to object's ManagedObject wrapper for internal access. Nov 12, 2024
aclegg3
aclegg3 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@jturner65 jturner65 merged commit 1d50fe1 into main Nov 13, 2024
9 checks passed
@jturner65 jturner65 deleted the BE_InternalAccessToObjWrappers branch November 13, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jturner65 @aclegg3 @facebook-github-bot