Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--[BE] - Baselink ID init via constant #2465

Merged
merged 4 commits into from
Sep 24, 2024
Merged

--[BE] - Baselink ID init via constant #2465

merged 4 commits into from
Sep 24, 2024

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This small PR adds a constant to replace the magic number '-1' used to reference the baselink ID for articulated objects. A few other magic numbers were replaced with more semantically meaningful constants, based on context.

How Has This Been Tested

Locally c++ and python tests pass

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 requested a review from aclegg3 September 9, 2024 13:27
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 9, 2024
@jturner65 jturner65 force-pushed the BE_StageAndLinkIdInit branch from c76a7c9 to ddcb9cc Compare September 10, 2024 13:23
@jturner65 jturner65 changed the base branch from main to dev September 13, 2024 12:44
@jturner65 jturner65 force-pushed the BE_StageAndLinkIdInit branch from ddcb9cc to 5b763ae Compare September 17, 2024 14:22
@jturner65 jturner65 force-pushed the BE_StageAndLinkIdInit branch from 5b763ae to 742db9e Compare September 18, 2024 15:32
@jturner65 jturner65 force-pushed the BE_StageAndLinkIdInit branch from 742db9e to 0e5ce57 Compare September 18, 2024 17:13
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jturner65 jturner65 merged commit c0b2110 into dev Sep 24, 2024
10 checks passed
@jturner65 jturner65 deleted the BE_StageAndLinkIdInit branch September 24, 2024 16:09
jturner65 added a commit to jturner65/habitat-sim that referenced this pull request Oct 29, 2024
* --system-wide constant for baseLink ID
* --use BASELINK_ID instead of magic number -1 to denote baseLink
* --Use ID_UNDEFINED for rigid object link ids.
* --more fixes
jturner65 pushed a commit that referenced this pull request Nov 4, 2024
* --[Bugfix] - Scene Reset Redundancy (#2470)
* --modify reset() to not perform redundant object re-placement
After successful scene creation, reset is called, but the objects have all already been placed in their initial positions.
* --fix bindings
Don't expose the boolean in reset to python, should only be consumed from Simulator::reconfigure
* --[BE] - Add ability to filter Configuration subconfigs (#2471)
* --add subconfig filtering process.
This function will remove any values and subconfigs from a Configuration that match those found within a passed Configuration.
* --minor naming clarification
* --expand Configuration tests to test filtering; rename test
Test only tests Configurations, so name appropriately
* --[Bugfix] - Address ObjectInstanceAttributes save issues (#2472)
* --access init instance attributes for an rigid/AO via const ref or copy
* --access sim directly to query for defaultCOMCorrection state
So that objects added to an existing scene will use the correct defaultCOMCorrection state.
* --verify requested type is appropriate
* --add queries for current state of Configuration fields
Query whether a field is a default value, a hidden value or backed by an enum (i.e. 'translated')
* --properly set enum-backed/'translated' string fields in instance attrs
* --add is_visible boolean for AOs
For instance consistency - not yet supported.
* --only set instance vals if not default config vals; clean up JSON write
Configuration now supports not writing initialization/default fields to JSON.
* --Add access to user_defined view and setter
* --better names for object init attrs and object instance  init attrs
* --use base obj's current state to build ObjectInstanceAttr and obj copy
* --only change fields if they are different than defaults.
* --[BE] - Baselink ID init via constant (#2465)
* --system-wide constant for baseLink ID
* --use BASELINK_ID instead of magic number -1 to denote baseLink
* --Use ID_UNDEFINED for rigid object link ids.
* --more fixes
* --[BE] - ManagedContainer updates and cleanups (#2475)
* --clean up handle query
* --move object library map settings to base class.
* --make managed container map member variables private.
* --verify templated accessor results are cast to legitimate type.
* --simplify caller-message arguments
* --clarify naming of existing dirty flag, in preparation of file-save-based flag.
* --move filepath check flag to base attributes to make available
* --treat pbr/ibl helper key as hidden field
* --provide rudiments of file-status dirty flags.
The purpose of this flag is to specify that a particular Managed File-based object has been registered in its Manager in a state that is different than that of its disk-based counterpart.
* --rename constructor-building method for clarity
* --[Bugfix] - Compare Configuration scalar doubles properly (#2478)
* --remove unnecessary magnum decorator
* --add and test support for scalar ConfigValues requiring fuzzy compare
This uses the same mechanism that Magnum constructs use, so results are consistent
* --separate Configuration fuzzy compare tests; minor updates
* --make sure comparisons only involve the number of non-hidden values
There is a possibility, albeit remote, that 2 otherwise identical configurations might have a different number of internal-use/hidden values and would appear to be different when they were, in fact, the same. Not anymore. Note, these are only accessible internally (in c++ source) and so the likelihood of this happening is vanishingly small.
* add a check, error meesage, and correction for 0 scale in box shapes (#2464)
Co-authored-by: aclegg3 <alexanderwclegg@gmail.com>
---------
Co-authored-by: John Turner <7strbass@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants