Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][conda] - Update conda build docker to centos8 #2427

Merged
merged 7 commits into from
Jul 12, 2024

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Jul 11, 2024

Motivation and Context

Our current conda build docker for linux is based on a centos 7 image.
centos7 reached end of life (EoL) in June 2024.
The mirror repos were moved to centos vault causing our current build to fail.

This PR updates the docker to centos 8.

How Has This Been Tested

CI conda build test passed.

On branch https://github.com/facebookresearch/habitat-sim/tree/alex-07_11-conda_deploy_test_rhel8 I deployed a test linux package which is currently available here. I was able to successfully install this package and run tests locally on Fedora 39.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested review from jturner65 and 0mdc July 11, 2024 22:42
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 11, 2024
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aclegg3
Copy link
Contributor Author

aclegg3 commented Jul 12, 2024

Merging this an testing the nightly today. If that works then I'll remove the test branch and package.

@aclegg3 aclegg3 merged commit 9ece203 into main Jul 12, 2024
9 of 10 checks passed
@aclegg3 aclegg3 deleted the alex-07_11-docker_centos_8 branch July 12, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants