Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum scipy version. #2403

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Update minimum scipy version. #2403

merged 1 commit into from
Jun 4, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Jun 4, 2024

Motivation and Context

This updates the minimum scipy version to match habitat-lab.

The current version is obsolete and vulnerable.

How Has This Been Tested

CI

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sorry, something went wrong.

@0mdc 0mdc requested review from jturner65 and aclegg3 June 4, 2024 19:58
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 4, 2024
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to sync this with lab

@0mdc 0mdc merged commit d808de4 into main Jun 4, 2024
10 checks passed
@0mdc 0mdc deleted the 0mdc/update_scipy branch June 4, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants