Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] - Disable new clone protection for git lfs #2397

Merged
merged 2 commits into from
May 16, 2024
Merged

[CI] - Disable new clone protection for git lfs #2397

merged 2 commits into from
May 16, 2024

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented May 16, 2024

Motivation and Context

Git LFS was broken on CI by new security measures git-lfs/git-lfs#5749

This PR disables the clone protections for pulling data from our HF repos.

How Has This Been Tested

CI

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested review from jturner65, jimmytyyang and 0mdc May 16, 2024 21:44
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 16, 2024
@aclegg3 aclegg3 changed the title Disable new clone protection for git lfs [CI] - Disable new clone protection for git lfs May 16, 2024
jimmytyyang
jimmytyyang approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@jimmytyyang jimmytyyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aclegg3 aclegg3 merged commit 1c73c15 into main May 16, 2024
6 of 10 checks passed
@aclegg3 aclegg3 deleted the alex-05_16-fix_ci_data_download branch May 16, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0mdc 0mdc 0mdc approved these changes

@jimmytyyang jimmytyyang jimmytyyang approved these changes

@jturner65 jturner65 Awaiting requested review from jturner65

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aclegg3 @jimmytyyang @0mdc @facebook-github-bot