Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add close() to replay renderer to allow for explicit resource release. #2145

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Add close() to replay renderer to allow for explicit resource release. #2145

merged 3 commits into from
Jun 30, 2023

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Jun 30, 2023

Motivation and Context

This adds an explicit close() method to replay renderer to ensure that resources aren't leaked when being used in Python.

See facebookresearch/habitat-lab#1436.

How Has This Been Tested

Tested locally and on facebookresearch/habitat-lab#1436.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@0mdc 0mdc requested a review from eundersander June 30, 2023 20:48
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 30, 2023
eundersander
eundersander reviewed Jun 30, 2023
View reviewed changes
Copy link
Contributor

@eundersander eundersander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's easy, can you call this close from one of our unit tests?

src/esp/sim/BatchReplayRenderer.cpp Show resolved Hide resolved
eundersander
eundersander approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@eundersander eundersander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0mdc 0mdc mentioned this pull request Jun 30, 2023
Merged
5 tasks
@0mdc 0mdc merged commit 0c7cedb into main Jun 30, 2023
@0mdc 0mdc deleted the replay_renderer_clear branch June 30, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eundersander eundersander eundersander approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0mdc @eundersander @facebook-github-bot