Fix INSTALL.md due to failure of conflict resolving #3915
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ramilbakhshyiev has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
INSTALL.md
Outdated
| @@ -130,8 +130,9 @@ Several options can be passed to CMake, among which: | |||
| - `-DCMAKE_BUILD_TYPE=Release` in order to enable generic compiler | |||
| optimization options (enables `-O3` on gcc for instance), | |||
| - `-DFAISS_OPT_LEVEL=avx2` in order to enable the required compiler flags to | |||
| generate code using optimized SIMD instructions (possible values are `generic`, | |||
| `avx2` and `avx512`, by increasing order of optimization), | |||
| generate code using optimized SIMD/Vector instructions. possible values are below: | |||
There was a problem hiding this comment.
nit: possible -> Possible -- please capitalize
INSTALL.md
Outdated
| generate code using optimized SIMD instructions (possible values are `generic`, | ||
| `avx2` and `avx512`, by increasing order of optimization), | ||
| generate code using optimized SIMD/Vector instructions. possible values are below: | ||
| - On x86\_64, `generic`, `avx2` and `avx512`, by increasing order of optimization, |
There was a problem hiding this comment.
nit: Consider not escaping the underscore for readability.
There was a problem hiding this comment.
#3929 has changed x86_64 to x86-64 , so I will follow that.
|
@toru-fukaya Would you forced-push |
toru-fukaya
force-pushed
the
revert-doc-change
branch
from
caa1c97 to
7acc5cb
Compare
|
@vorj done |
|
@ramilbakhshyiev has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@toru-fukaya thank you! |
|
@ramilbakhshyiev merged this pull request in e017c35. |
aalekhpatel07
pushed a commit
to aalekhpatel07/faiss
that referenced
this pull request
Oct 17, 2024
…#3915) Summary: facebookresearch#2943 had removed about SVE information (added on facebookresearch#2886 ) on the installation document. This PR fixes it. This PR changes only the document, so it doesn't affect software behavior. Pull Request resolved: facebookresearch#3915 Reviewed By: asadoughi Differential Revision: D63967842 Pulled By: ramilbakhshyiev fbshipit-source-id: ce0a0bfe591cb75b504cdf6362b5e8ed156928d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2943 had removed about SVE information (added on #2886 ) on the installation document. This PR fixes it.
This PR changes only the document, so it doesn't affect software behavior.