Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put idx_t in the faiss namespace #2582

Closed
wants to merge 1 commit into from

Conversation

mdouze
Copy link
Contributor

@mdouze mdouze commented Nov 21, 2022

Summary:
A few more or less cosmetic improvements

  • Index::idx_t was in the Index object, which does not make much sense, this diff moves it to faiss::idx_t
  • replace multiprocessing.dummy with multiprocessing.pool
  • add Alexandr as a core contributor of Faiss in the README ;-)
for i in $( find . -name \*.cu -o -name \*.cuh -o -name \*.h -o -name \*.cpp ) ; do
  sed -i s/Index::idx_t/idx_t/ $i
done

Differential Revision: D41437507

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41437507

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41437507

mdouze added a commit to mdouze/faiss that referenced this pull request Nov 21, 2022
Summary:
Pull Request resolved: facebookresearch#2582

A few more or less cosmetic improvements
* Index::idx_t was in the Index object, which does not make much sense, this diff moves it to faiss::idx_t
* replace multiprocessing.dummy with multiprocessing.pool
* add Alexandr as a core contributor of Faiss in the README ;-)

```
for i in $( find . -name \*.cu -o -name \*.cuh -o -name \*.h -o -name \*.cpp ) ; do
  sed -i s/Index::idx_t/idx_t/ $i
done
```

For the fbcode deps:
```
for i in $( fbgs Index::idx_t --exclude fbcode/faiss -l ) ; do
   sed -i s/Index::idx_t/idx_t/ $i
done
```

Differential Revision: D41437507

fbshipit-source-id: 2d7cc417d4b8cfac30d89fe37f9dbfd50fa8772c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41437507

mdouze added a commit to mdouze/faiss that referenced this pull request Nov 23, 2022
Summary:
Pull Request resolved: facebookresearch#2582

A few more or less cosmetic improvements
* Index::idx_t was in the Index object, which does not make much sense, this diff moves it to faiss::idx_t
* replace multiprocessing.dummy with multiprocessing.pool
* add Alexandr as a core contributor of Faiss in the README ;-)

```
for i in $( find . -name \*.cu -o -name \*.cuh -o -name \*.h -o -name \*.cpp ) ; do
  sed -i s/Index::idx_t/idx_t/ $i
done
```

For the fbcode deps:
```
for i in $( fbgs Index::idx_t --exclude fbcode/faiss -l ) ; do
   sed -i s/Index::idx_t/idx_t/ $i
done
```

Differential Revision: D41437507

fbshipit-source-id: f5f7cc3a6807a6861c177e64d2034b2dc07fdc8f
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41437507

mdouze added a commit to mdouze/faiss that referenced this pull request Nov 23, 2022
Summary:
Pull Request resolved: facebookresearch#2582

A few more or less cosmetic improvements
* Index::idx_t was in the Index object, which does not make much sense, this diff moves it to faiss::idx_t
* replace multiprocessing.dummy with multiprocessing.pool
* add Alexandr as a core contributor of Faiss in the README ;-)

```
for i in $( find . -name \*.cu -o -name \*.cuh -o -name \*.h -o -name \*.cpp ) ; do
  sed -i s/Index::idx_t/idx_t/ $i
done
```

For the fbcode deps:
```
for i in $( fbgs Index::idx_t --exclude fbcode/faiss -l ) ; do
   sed -i s/Index::idx_t/idx_t/ $i
done
```

Differential Revision: D41437507

fbshipit-source-id: 550d8eb85e78e6abf26e97c8877778046b455d11
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41437507

mdouze added a commit to mdouze/faiss that referenced this pull request Nov 24, 2022
Summary:
Pull Request resolved: facebookresearch#2582

A few more or less cosmetic improvements
* Index::idx_t was in the Index object, which does not make much sense, this diff moves it to faiss::idx_t
* replace multiprocessing.dummy with multiprocessing.pool
* add Alexandr as a core contributor of Faiss in the README ;-)

```
for i in $( find . -name \*.cu -o -name \*.cuh -o -name \*.h -o -name \*.cpp ) ; do
  sed -i s/Index::idx_t/idx_t/ $i
done
```

For the fbcode deps:
```
for i in $( fbgs Index::idx_t --exclude fbcode/faiss -l ) ; do
   sed -i s/Index::idx_t/idx_t/ $i
done
```

Differential Revision: D41437507

fbshipit-source-id: 38cb693f2358ba785491bd923d9a3fb30cd4c419
mdouze added a commit to mdouze/faiss that referenced this pull request Nov 24, 2022
Summary:
Pull Request resolved: facebookresearch#2582

A few more or less cosmetic improvements
* Index::idx_t was in the Index object, which does not make much sense, this diff moves it to faiss::idx_t
* replace multiprocessing.dummy with multiprocessing.pool
* add Alexandr as a core contributor of Faiss in the README ;-)

```
for i in $( find . -name \*.cu -o -name \*.cuh -o -name \*.h -o -name \*.cpp ) ; do
  sed -i s/Index::idx_t/idx_t/ $i
done
```

For the fbcode deps:
```
for i in $( fbgs Index::idx_t --exclude fbcode/faiss -l ) ; do
   sed -i s/Index::idx_t/idx_t/ $i
done
```

Differential Revision: D41437507

fbshipit-source-id: a2adeb1d25b2737402223c42771ae4130f1bed85
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41437507

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41437507

mdouze added a commit to mdouze/faiss that referenced this pull request Nov 24, 2022
Summary:
Pull Request resolved: facebookresearch#2582

A few more or less cosmetic improvements
* Index::idx_t was in the Index object, which does not make much sense, this diff moves it to faiss::idx_t
* replace multiprocessing.dummy with multiprocessing.pool
* add Alexandr as a core contributor of Faiss in the README ;-)

```
for i in $( find . -name \*.cu -o -name \*.cuh -o -name \*.h -o -name \*.cpp ) ; do
  sed -i s/Index::idx_t/idx_t/ $i
done
```

For the fbcode deps:
```
for i in $( fbgs Index::idx_t --exclude fbcode/faiss -l ) ; do
   sed -i s/Index::idx_t/idx_t/ $i
done
```

Differential Revision: D41437507

fbshipit-source-id: c790b42ff5a72e042e83514f578b3a04a4ee737e
Summary:
Pull Request resolved: facebookresearch#2582

A few more or less cosmetic improvements
* Index::idx_t was in the Index object, which does not make much sense, this diff moves it to faiss::idx_t
* replace multiprocessing.dummy with multiprocessing.pool
* add Alexandr as a core contributor of Faiss in the README ;-)

```
for i in $( find . -name \*.cu -o -name \*.cuh -o -name \*.h -o -name \*.cpp ) ; do
  sed -i s/Index::idx_t/idx_t/ $i
done
```

For the fbcode deps:
```
for i in $( fbgs Index::idx_t --exclude fbcode/faiss -l ) ; do
   sed -i s/Index::idx_t/idx_t/ $i
done
```

Differential Revision: D41437507

fbshipit-source-id: 4fb6f6fc642a524452da6c304994a7d7cef7d31e
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41437507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants