-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put idx_t in the faiss namespace #2582
Conversation
This pull request was exported from Phabricator. Differential Revision: D41437507 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D41437507 |
Summary: Pull Request resolved: facebookresearch#2582 A few more or less cosmetic improvements * Index::idx_t was in the Index object, which does not make much sense, this diff moves it to faiss::idx_t * replace multiprocessing.dummy with multiprocessing.pool * add Alexandr as a core contributor of Faiss in the README ;-) ``` for i in $( find . -name \*.cu -o -name \*.cuh -o -name \*.h -o -name \*.cpp ) ; do sed -i s/Index::idx_t/idx_t/ $i done ``` For the fbcode deps: ``` for i in $( fbgs Index::idx_t --exclude fbcode/faiss -l ) ; do sed -i s/Index::idx_t/idx_t/ $i done ``` Differential Revision: D41437507 fbshipit-source-id: 2d7cc417d4b8cfac30d89fe37f9dbfd50fa8772c
d2890da
to
fb15cec
Compare
This pull request was exported from Phabricator. Differential Revision: D41437507 |
Summary: Pull Request resolved: facebookresearch#2582 A few more or less cosmetic improvements * Index::idx_t was in the Index object, which does not make much sense, this diff moves it to faiss::idx_t * replace multiprocessing.dummy with multiprocessing.pool * add Alexandr as a core contributor of Faiss in the README ;-) ``` for i in $( find . -name \*.cu -o -name \*.cuh -o -name \*.h -o -name \*.cpp ) ; do sed -i s/Index::idx_t/idx_t/ $i done ``` For the fbcode deps: ``` for i in $( fbgs Index::idx_t --exclude fbcode/faiss -l ) ; do sed -i s/Index::idx_t/idx_t/ $i done ``` Differential Revision: D41437507 fbshipit-source-id: f5f7cc3a6807a6861c177e64d2034b2dc07fdc8f
fb15cec
to
8b19fad
Compare
This pull request was exported from Phabricator. Differential Revision: D41437507 |
Summary: Pull Request resolved: facebookresearch#2582 A few more or less cosmetic improvements * Index::idx_t was in the Index object, which does not make much sense, this diff moves it to faiss::idx_t * replace multiprocessing.dummy with multiprocessing.pool * add Alexandr as a core contributor of Faiss in the README ;-) ``` for i in $( find . -name \*.cu -o -name \*.cuh -o -name \*.h -o -name \*.cpp ) ; do sed -i s/Index::idx_t/idx_t/ $i done ``` For the fbcode deps: ``` for i in $( fbgs Index::idx_t --exclude fbcode/faiss -l ) ; do sed -i s/Index::idx_t/idx_t/ $i done ``` Differential Revision: D41437507 fbshipit-source-id: 550d8eb85e78e6abf26e97c8877778046b455d11
8b19fad
to
c187061
Compare
This pull request was exported from Phabricator. Differential Revision: D41437507 |
Summary: Pull Request resolved: facebookresearch#2582 A few more or less cosmetic improvements * Index::idx_t was in the Index object, which does not make much sense, this diff moves it to faiss::idx_t * replace multiprocessing.dummy with multiprocessing.pool * add Alexandr as a core contributor of Faiss in the README ;-) ``` for i in $( find . -name \*.cu -o -name \*.cuh -o -name \*.h -o -name \*.cpp ) ; do sed -i s/Index::idx_t/idx_t/ $i done ``` For the fbcode deps: ``` for i in $( fbgs Index::idx_t --exclude fbcode/faiss -l ) ; do sed -i s/Index::idx_t/idx_t/ $i done ``` Differential Revision: D41437507 fbshipit-source-id: 38cb693f2358ba785491bd923d9a3fb30cd4c419
c187061
to
488f821
Compare
Summary: Pull Request resolved: facebookresearch#2582 A few more or less cosmetic improvements * Index::idx_t was in the Index object, which does not make much sense, this diff moves it to faiss::idx_t * replace multiprocessing.dummy with multiprocessing.pool * add Alexandr as a core contributor of Faiss in the README ;-) ``` for i in $( find . -name \*.cu -o -name \*.cuh -o -name \*.h -o -name \*.cpp ) ; do sed -i s/Index::idx_t/idx_t/ $i done ``` For the fbcode deps: ``` for i in $( fbgs Index::idx_t --exclude fbcode/faiss -l ) ; do sed -i s/Index::idx_t/idx_t/ $i done ``` Differential Revision: D41437507 fbshipit-source-id: a2adeb1d25b2737402223c42771ae4130f1bed85
488f821
to
d0e757b
Compare
This pull request was exported from Phabricator. Differential Revision: D41437507 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D41437507 |
Summary: Pull Request resolved: facebookresearch#2582 A few more or less cosmetic improvements * Index::idx_t was in the Index object, which does not make much sense, this diff moves it to faiss::idx_t * replace multiprocessing.dummy with multiprocessing.pool * add Alexandr as a core contributor of Faiss in the README ;-) ``` for i in $( find . -name \*.cu -o -name \*.cuh -o -name \*.h -o -name \*.cpp ) ; do sed -i s/Index::idx_t/idx_t/ $i done ``` For the fbcode deps: ``` for i in $( fbgs Index::idx_t --exclude fbcode/faiss -l ) ; do sed -i s/Index::idx_t/idx_t/ $i done ``` Differential Revision: D41437507 fbshipit-source-id: c790b42ff5a72e042e83514f578b3a04a4ee737e
d0e757b
to
cdb3cd6
Compare
Summary: Pull Request resolved: facebookresearch#2582 A few more or less cosmetic improvements * Index::idx_t was in the Index object, which does not make much sense, this diff moves it to faiss::idx_t * replace multiprocessing.dummy with multiprocessing.pool * add Alexandr as a core contributor of Faiss in the README ;-) ``` for i in $( find . -name \*.cu -o -name \*.cuh -o -name \*.h -o -name \*.cpp ) ; do sed -i s/Index::idx_t/idx_t/ $i done ``` For the fbcode deps: ``` for i in $( fbgs Index::idx_t --exclude fbcode/faiss -l ) ; do sed -i s/Index::idx_t/idx_t/ $i done ``` Differential Revision: D41437507 fbshipit-source-id: 4fb6f6fc642a524452da6c304994a7d7cef7d31e
This pull request was exported from Phabricator. Differential Revision: D41437507 |
cdb3cd6
to
789d090
Compare
Summary:
A few more or less cosmetic improvements
Differential Revision: D41437507