This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
[fix #49] Invalid use of function align_and_update_state_dicts
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function `align_and_update_state_dicts` has return type None and is assigned to `checkpoint['model']` leading to issue #49.
facebook-github-bot
added
the
CLA Signed
|
Hi @yujheli, can you please review this? |
|
@bitbeast18 I currently did not have full access to this repo. I will test it and discuss it with my previous manager to approve it. Thanks. |
|
@XiaoliangDai Could you help me to approve this merge? Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
align_and_update_state_dictshas return type None and is assigned tocheckpoint['model']leading to issue #49.