Update fbos deps to v2024.05.20.00 #9968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
@majetideepak FYI. |
czentgr
force-pushed
the
cz_advance_fbos_deps
branch
from
702382f to
1df7a17
Compare
majetideepak
approved these changes
May 30, 2024
czentgr
force-pushed
the
cz_advance_fbos_deps
branch
from
1df7a17 to
99394f8
Compare
czentgr
force-pushed
the
cz_advance_fbos_deps
branch
4 times, most recently
from
43f7011 to
86328ef
Compare
|
@kgpai Can you please help commit this? |
|
@majetideepak @assignUser please add the "ready-to-merge" whenever you want this merged :) |
|
@pedroerp yes, the label has been working well! We are waiting on a rebase so CI will be green :) |
|
@czentgr setup-centos9.sh needs an update as well. |
czentgr
force-pushed
the
cz_advance_fbos_deps
branch
from
86328ef to
c94ba03
Compare
majetideepak
added
the
ready-to-merge
|
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kagamiori merged this pull request in 9558dcb. |
|
Conbench analyzed the 1 benchmark run on commit There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main fix is for CentOS9 to find libdwarf in the correct system install path (found in folder
libdwarf-0). This was added at the end of April here facebook/folly@ebd05bfI decided not to use the latest due to an error with MacOS building fbthrift