Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade fbos dependencies to v2024.04.01.00 (from v2024.02.26.00) #9372

Closed
wants to merge 1 commit into from
Closed

upgrade fbos dependencies to v2024.04.01.00 (from v2024.02.26.00) #9372

wants to merge 1 commit into from

Conversation

czentgr
Copy link
Collaborator

@czentgr czentgr commented Apr 4, 2024

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 4, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 4, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit a1f1b36
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/661016a77725510009a026a4

@czentgr
Copy link
Collaborator Author

czentgr commented Apr 4, 2024

Fixes issue #9339

assignUser
assignUser approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM, the fuzzer fail seems unrelated but best that someone with domain knowledge has a look.

@czentgr
Copy link
Collaborator Author

czentgr commented Apr 5, 2024

I've created #9376 to record the failure. Unfortunately, the iteration seed is not printed to the log - maybe an additional bug/issue - and so I can't check with the old version to see if it is related to the new fbos version.

I also checked that gcc11 is good with the selected version. When the velox submodule is updated in prestissimo proxygen needs to be updated and use this version.

@kgpai FYI

@czentgr czentgr marked this pull request as ready for review April 5, 2024 05:54
@czentgr czentgr force-pushed the cz_update_fbos_v2024.04.01 branch from 866e81a to a1f1b36 Compare April 5, 2024 15:20
@pedroerp
Copy link
Contributor

pedroerp commented Apr 5, 2024

Thank you guys

@facebook-github-bot
Copy link
Contributor

@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@czentgr
Copy link
Collaborator Author

czentgr commented Apr 5, 2024

@pedroerp Thank you! When this lands I will update the velox submodule in prestissimo and ensure proxygen is updated then as well to avoid issues. I have a PR to update proxygen in prestissimo to match the (soon outdated) version.

@facebook-github-bot
Copy link
Contributor

@pedroerp merged this pull request in 5fed974.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit 5fed9747.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Joe-Abraham pushed a commit to Joe-Abraham/velox that referenced this pull request Jun 7, 2024
@czentgr @Joe-Abraham
upgrade fbos dependencies to v2024.04.01.00 (from v2024.02.26.00) (fa…
cd94633 
…cebookincubator#9372)

Summary: Pull Request resolved: facebookincubator#9372

Reviewed By: xiaoxmeng

Differential Revision: D55803918

Pulled By: pedroerp

fbshipit-source-id: 78255e2fad624c1633c5b6c773a179f5f2be1689
@czentgr czentgr deleted the cz_update_fbos_v2024.04.01 branch July 31, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assignUser assignUser assignUser approved these changes

@majetideepak majetideepak majetideepak approved these changes

@kgpai kgpai kgpai approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@czentgr @pedroerp @facebook-github-bot @kgpai @majetideepak @assignUser