Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow transform functions to return different nodes (try 2) #44

Merged
merged 4 commits into from
Dec 14, 2018
Merged

Allow transform functions to return different nodes (try 2) #44

merged 4 commits into from
Dec 14, 2018

Conversation

thatch
Copy link
Contributor

@thatch thatch commented Dec 14, 2018

This replaces #15. Cleaned up, rebased, and added tests.

Closes #14.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 14, 2018
@thatch thatch changed the title Allow transform functions to return different nodes Allow transform functions to return different nodes (try 2) Dec 14, 2018
@amyreese amyreese merged commit 5d0a017 into facebookincubator:master Dec 14, 2018
@syrusakbary
Copy link
Contributor

Much better than my PR.

Keep up the good work! 👍

@thatch thatch deleted the transform-node-fix branch December 17, 2018 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyreese amyreese amyreese approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thatch @syrusakbary @amyreese @facebook-github-bot