Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Node.js 20 to build #26693

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Allow Node.js 20 to build #26693

merged 1 commit into from
Apr 21, 2023

Conversation

kassens
Copy link
Member

@kassens kassens commented Apr 21, 2023

This is stable and appears to build w/o problem. I don't see why we should disallow it.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 21, 2023
@kassens kassens marked this pull request as ready for review April 21, 2023 17:37
@react-sizebot
Copy link

Comparing: c57a0f6...d897fdc

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 163.95 kB 163.95 kB = 51.67 kB 51.67 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 167.70 kB 167.70 kB = 52.81 kB 52.81 kB
facebook-www/ReactDOM-prod.classic.js = 566.07 kB 566.07 kB = 100.25 kB 100.25 kB
facebook-www/ReactDOM-prod.modern.js = 549.80 kB 549.80 kB = 97.57 kB 97.57 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against d897fdc

@gaearon gaearon merged commit 5d7ebb4 into facebook:main Apr 21, 2023
@kassens kassens deleted the node20 branch April 21, 2023 18:26
kassens added a commit that referenced this pull request Apr 21, 2023
This is stable and appears to build w/o problem. I don't see why we
should disallow it.
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
This is stable and appears to build w/o problem. I don't see why we
should disallow it.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
This is stable and appears to build w/o problem. I don't see why we
should disallow it.

DiffTrain build for commit 5d7ebb4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants