Autogenerate TypeScript declaration files #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
thegreatercurve
force-pushed
the
type-generation-experiment
branch
from
4672391 to
4b42308
Compare
thegreatercurve
requested review from
trueadm,
zurfyx,
fantactuka,
acywatson and
tylerjbainbridge
as code owners
thegreatercurve
force-pushed
the
type-generation-experiment
branch
from
2add202 to
23d888f
Compare
trueadm
approved these changes
Jun 7, 2022
thegreatercurve
force-pushed
the
type-generation-experiment
branch
from
23d888f to
38ea5ca
Compare
thegreatercurve
force-pushed
the
type-generation-experiment
branch
from
38ea5ca to
6f8ef6e
Compare
thegreatercurve
force-pushed
the
type-generation-experiment
branch
from
87b42f4 to
e87fa79
Compare
thegreatercurve
force-pushed
the
type-generation-experiment
branch
from
e87fa79 to
da655ce
Compare
thegreatercurve
force-pushed
the
type-generation-experiment
branch
from
da655ce to
f1a30de
Compare
thegreatercurve
force-pushed
the
type-generation-experiment
branch
from
f1a30de to
946f7bb
Compare
|
Sorry to ask but can I get a re-review? I had to fix some bugs in the playground that weren't covered in the original tsconfig |
thegreatercurve
force-pushed
the
type-generation-experiment
branch
from
946f7bb to
95862ea
Compare
trueadm
approved these changes
Jun 14, 2022
zurfyx
approved these changes
Jun 14, 2022
|
That is a great move. I see the flow folders are still present. If an API changes, the d.ts will be automatically generated, does the flow files still need to be manually updated (disclaimer: I have never used flow). Nothing is written about that in https://github.com/facebook/lexical/blob/main/CONTRIBUTING.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.d.tsfiles and set absolute path aliases to.tsfiles.distfolders.Tested the integration by running
npm run prepare-releaseand then copying files over to a test TypeScript integration of Lexical which uses bothlexicaland@lexical/react,