Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/ktfmt
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.49
Choose a base ref
...
head repository: facebook/ktfmt
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.50
Choose a head ref
  • 8 commits
  • 12 files changed
  • 5 contributors

Commits on Apr 24, 2024

  1. Bump version to 0.50-SNAPSHOT

    Reviewed By: strulovich
    
    Differential Revision: D56503356
    
    fbshipit-source-id: 65bb80812944edc60988644ccb0356686cfc267b
    Nivaldo Bondança authored and facebook-github-bot committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    8b37094 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Add pre commit hooks to readme (#462)

    Summary:
    I've recently added support for ktfmt to pre-commit hooks.
    
    macisamuele/language-formatters-pre-commit-hooks#196
    
    I thought it'd be worth mentioning in the README.
    
    Pull Request resolved: #462
    
    Reviewed By: cortinico
    
    Differential Revision: D56680818
    
    Pulled By: hick209
    
    fbshipit-source-id: 3d6482e3d550b5d04647d6582ac3348aac52f9c4
    aandres authored and facebook-github-bot committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    f3a2e54 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. feat: add homebrew installation note (#468)

    Summary:
    closes #312
    
    relates to Homebrew/homebrew-core#162375
    
    Pull Request resolved: #468
    
    Differential Revision: D57621792
    
    Pulled By: hick209
    
    fbshipit-source-id: a62db1c685fc318e14708d86b21c0b667033337a
    chenrui333 authored and facebook-github-bot committed May 22, 2024
    Configuration menu
    Copy the full SHA
    9a916b7 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Refactor CLI argument parsing (#467)

    Summary:
    Working towards #391.
    
    I wanted to open this to get feedback on the approach.
    
    I could have chosen to use exceptions, but I find sealed classes much more composable and I already anticipate adding another class to the `ParseResult` hierarchy to represent a situation where a message needs to be shown to the user but isn't an error (`--help` is the obvious example).
    
    Closes #465 more or less as a side-effect.
    
    Pull Request resolved: #467
    
    Reviewed By: strulovich
    
    Differential Revision: D58136233
    
    Pulled By: hick209
    
    fbshipit-source-id: 85662e7b5f19195c4bb4c9c28caa02ae224ede52
    Joseph Cooper authored and facebook-github-bot committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    26a24ae View commit details
    Browse the repository at this point in the history
  2. Fix issue with context receive in lambdas

    Summary:
    Fixes issue reported by at #471
    
    Formatting might be a bit odd, but the goal of this diff is solely to stop of the issue with running ktfmt.
    
    Reviewed By: strulovich
    
    Differential Revision: D58194198
    
    fbshipit-source-id: 51123c1b3fef65c2c0803689c9173cb7c50cb41f
    Nivaldo Bondança authored and facebook-github-bot committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    dafd1cb View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Don't reorder @sample tag (#406)

    Summary:
    Some users place `sample` tags at the beginning (before any other tag). This conflicts with our fixed ordering of kdoc tags.
    
    Since there's good reason for this ordering, don't reorder `sample` tags (but only if they're at the beginning already). This way we'll avoid messing with code that's already been formatted with `ktfmt` while supporting this use case.
    
    See [#406](#406) for more info.
    
    Closes #406
    
    Reviewed By: cortinico, hick209
    
    Differential Revision: D58198948
    
    fbshipit-source-id: 00335bdb04ccc668419e1443196fdce4103a763b
    David Torosyan authored and facebook-github-bot committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    2ba3b09 View commit details
    Browse the repository at this point in the history
  2. Fix whitespaces in test

    Summary: The previous change (D58198948) had some unnecessary whitespace in the tests, breaking them.
    
    Reviewed By: hick209
    
    Differential Revision: D58247182
    
    fbshipit-source-id: 99fc1c061b971ed9f88ff9e8c3c8d8031f9ddd08
    David Torosyan authored and facebook-github-bot committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    babb277 View commit details
    Browse the repository at this point in the history
  3. Bump version to 0.50

    Reviewed By: davidtorosyan
    
    Differential Revision: D58257382
    
    fbshipit-source-id: d00e89a0b15ee0ec1f7b1702c1a46894177a16b6
    Nivaldo Bondança authored and facebook-github-bot committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    acffffa View commit details
    Browse the repository at this point in the history
Loading