Remove extra semis in RN #1037
Closed
Remove extra semis in RN #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46765640 |
itsjohnward
pushed a commit
to itsjohnward/hermes
that referenced
this pull request
Jun 26, 2023
Summary: Pull Request resolved: facebook#1037 X-link: facebook/react-native#38068 ## Changelog: [Internal] - Remove extra semis called out by -Wextra-semi compiler flag Reviewed By: cipolleschi Differential Revision: D46765640 fbshipit-source-id: c513598472dbd256f07ed54773561b173f95045e
itsjohnward
force-pushed
the
export-D46765640
branch
from
b3f3d0f to
fa6445a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46765640 |
itsjohnward
pushed a commit
to itsjohnward/react-native
that referenced
this pull request
Jun 26, 2023
Summary: X-link: facebook/hermes#1037 Pull Request resolved: facebook#38068 ## Changelog: [Internal] - Remove extra semis called out by -Wextra-semi compiler flag Reviewed By: cipolleschi Differential Revision: D46765640 fbshipit-source-id: 6111e85411e385d2aef9d7407e9b2bfc0011e786
|
This pull request was exported from Phabricator. Differential Revision: D46765640 |
itsjohnward
pushed a commit
to itsjohnward/hermes
that referenced
this pull request
Jun 27, 2023
Summary: Pull Request resolved: facebook#1037 X-link: facebook/react-native#38068 ## Changelog: [Internal] - Remove extra semis called out by -Wextra-semi compiler flag Reviewed By: cipolleschi Differential Revision: D46765640 fbshipit-source-id: a7dfa9452e1bd90b5ad3b0c42552d36b93d98a7f
itsjohnward
force-pushed
the
export-D46765640
branch
from
fa6445a to
976d9ef
Compare
itsjohnward
pushed a commit
to itsjohnward/react-native
that referenced
this pull request
Jun 27, 2023
Summary: X-link: facebook/hermes#1037 Pull Request resolved: facebook#38068 ## Changelog: [Internal] - Remove extra semis called out by -Wextra-semi compiler flag Reviewed By: cipolleschi Differential Revision: D46765640 fbshipit-source-id: 0aeb2e42c7c2a2cb2e6842637c5f4f1cbc096e87
itsjohnward
pushed a commit
to itsjohnward/hermes
that referenced
this pull request
Jun 27, 2023
Summary: Pull Request resolved: facebook#1037 X-link: facebook/react-native#38068 ## Changelog: [Internal] - Remove extra semis called out by -Wextra-semi compiler flag Reviewed By: cipolleschi Differential Revision: D46765640 fbshipit-source-id: 2a7d8eeb6cb92741e6869ac4989df28756b1f095
itsjohnward
force-pushed
the
export-D46765640
branch
from
976d9ef to
f9493d7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46765640 |
itsjohnward
pushed a commit
to itsjohnward/react-native
that referenced
this pull request
Jun 27, 2023
Summary: X-link: facebook/hermes#1037 Pull Request resolved: facebook#38068 ## Changelog: [Internal] - Remove extra semis called out by -Wextra-semi compiler flag Reviewed By: cipolleschi Differential Revision: D46765640 fbshipit-source-id: a487ec6632e97e66cb0054b2aea6950766ec4289
itsjohnward
pushed a commit
to itsjohnward/react-native
that referenced
this pull request
Jul 5, 2023
Summary: X-link: facebook/hermes#1037 Pull Request resolved: facebook#38068 ## Changelog: [Internal] - Remove extra semis called out by -Wextra-semi compiler flag Reviewed By: cipolleschi Differential Revision: D46765640 fbshipit-source-id: 7f409ba98b18b1f73f2b8fc4225c6764eecd3a07
itsjohnward
pushed a commit
to itsjohnward/hermes
that referenced
this pull request
Jul 5, 2023
Summary: Pull Request resolved: facebook#1037 X-link: facebook/react-native#38068 ## Changelog: [Internal] - Remove extra semis called out by -Wextra-semi compiler flag Reviewed By: cipolleschi Differential Revision: D46765640 fbshipit-source-id: e7cdf496cd49a09b4e9cb09f009050434d560d53
itsjohnward
force-pushed
the
export-D46765640
branch
from
f9493d7 to
05e1a83
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46765640 |
itsjohnward
pushed a commit
to itsjohnward/react-native
that referenced
this pull request
Jul 5, 2023
Summary: X-link: facebook/hermes#1037 Pull Request resolved: facebook#38068 ## Changelog: [Internal] - Remove extra semis called out by -Wextra-semi compiler flag Reviewed By: cipolleschi Differential Revision: D46765640 fbshipit-source-id: 1dc9f660da0af954fc3479d472e0b150e752c483
Summary: Pull Request resolved: facebook#1037 X-link: facebook/react-native#38068 ## Changelog: [Internal] - Remove extra semis called out by -Wextra-semi compiler flag Reviewed By: cipolleschi Differential Revision: D46765640 fbshipit-source-id: 9e9ff0cdeac49848ba31c1636f270fd730bf8acb
itsjohnward
force-pushed
the
export-D46765640
branch
from
05e1a83 to
d452bc3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46765640 |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Jul 5, 2023
Summary: X-link: facebook/hermes#1037 Pull Request resolved: #38068 ## Changelog: [Internal] - Remove extra semis called out by -Wextra-semi compiler flag Reviewed By: cipolleschi Differential Revision: D46765640 fbshipit-source-id: 376255d8b3e94620a3a0768ca1cecd5431633136
|
This pull request has been merged in 9b0282e. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
Summary: Original Author: itsjohnward@meta.com Original Git: 9b0282e Pull Request resolved: #1037 X-link: facebook/react-native#38068 ## Changelog: [Internal] - Remove extra semis called out by -Wextra-semi compiler flag Original Reviewed By: cipolleschi Original Revision: D46765640 Reviewed By: neildhar Differential Revision: D47690621 fbshipit-source-id: cd884a1c16503a984551d3e331a6b4f238adc3ac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] - Remove extra semis called out by -Wextra-semi compiler flag
Reviewed By: cipolleschi
Differential Revision: D46765640