Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(v2): dogfooding: add huge sidebar for testing purposes #5130

Merged
merged 2 commits into from
Jul 8, 2021
Merged

test(v2): dogfooding: add huge sidebar for testing purposes #5130

merged 2 commits into from
Jul 8, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jul 8, 2021

Motivation

We have a lot of sites with very large sidebars (generally auto-generated from reference APIs)

We should optimize for such cases.

Adding an artificially large sidebar to our own site so that we can more easily test:

  • perf of the UI
  • size of generated assets (HTML page rendering that sidebar)
  • perf of build time (which are capped to a given threshold by CI, but it's hard to measure efficiently)

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

tests

Related PRs

#4753
#5099

@slorber slorber added pr: maintenance This PR does not produce any behavior differences to end users when upgrading. pr: performance This PR does not add a new behavior, but existing behaviors will be more memory- / time-efficient. labels Jul 8, 2021
@slorber slorber requested a review from lex111 as a code owner July 8, 2021 17:58
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 8, 2021
@netlify
Copy link

netlify bot commented Jul 8, 2021 •
edited
Loading

✔️ [V2]

🔨 Explore the source changes: f35ced6

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60e73ea7177595000863eea6

😎 Browse the preview: https://deploy-preview-5130--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jul 8, 2021 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 79
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5130--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Jul 8, 2021 •
edited
Loading

Size Change: +130 kB (+17%) ⚠️

Total Size: 904 kB

Filename Size Change
website/.docusaurus/globalData.json 58.8 kB +103 B (0%)
website/build/assets/js/main.********.js 447 kB +358 B (0%)
website/build/docs-tests/index.html 131 kB +104 kB (+386%) 🆘
website/build/docs-tests/standalone/index.html 25.3 kB +25.3 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.6 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 68.8 kB 0 B
website/build/docs/index.html 51.4 kB -1 B (0%)
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 33.6 kB 0 B

compressed-size-action

@slorber slorber changed the title tests(v2): dogfooding: add huge sidebar for testing purposes test(v2): dogfooding: add huge sidebar for testing purposes Jul 8, 2021
@slorber slorber merged commit f03479f into master Jul 8, 2021
@slorber slorber deleted the slorber/dogfood-huge-sidebar branch August 17, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading. pr: performance This PR does not add a new behavior, but existing behaviors will be more memory- / time-efficient.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slorber @facebook-github-bot