Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(translations): fix wrong Estonian (et) translations and typos #10344

Merged
merged 9 commits into from
Aug 9, 2024
Merged

fix(translations): fix wrong Estonian (et) translations and typos #10344

merged 9 commits into from
Aug 9, 2024

Conversation

Gekd
Copy link
Contributor

@Gekd Gekd commented Jul 28, 2024

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Fix Estonian default translations.

Related issues/PRs

#3526

@Gekd Gekd requested review from slorber and Josh-Cena as code owners July 28, 2024 17:12
@facebook-github-bot
Copy link
Contributor

Hi @Gekd!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify Netlify
Copy link

netlify bot commented Jul 28, 2024 •
edited
Loading

✅ [V2]

Name Link
🔨 Latest commit 43b2df1
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/66b5eaaefa75ff0008fc8091
😎 Deploy Preview https://deploy-preview-10344--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 28, 2024 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 70 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 56 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 74 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 69 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 47 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 69 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟠 86 Report

@slorber slorber changed the title Fixed wrong et translations and typos fix(translations): fix wrong Estonian (et) translations and typos Jul 29, 2024
slorber
slorber requested changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,

LGTM but I don't speak Estonian 😅

Little linting issues

This language has only been added recently. Can you help review it @chirbard please?

packages/docusaurus-theme-translations/locales/et/theme-search-algolia.json Outdated Show resolved Hide resolved
chirbard
chirbard reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@chirbard chirbard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments that should be fixed. Everything else looks good to me.

packages/docusaurus-theme-translations/locales/et/theme-search-algolia.json Outdated Show resolved Hide resolved
Gekd
Gekd commented Jul 30, 2024
View reviewed changes
Copy link
Contributor Author

@Gekd Gekd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed your comments.

chirbard
chirbard reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@chirbard chirbard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slorber
Copy link
Collaborator

slorber commented Jul 30, 2024

@Gekd thanks

We need you to sign the CLA. I can't merge the PR otherwise.

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jul 30, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 30, 2024
@Gekd
Copy link
Contributor Author

Gekd commented Aug 9, 2024

Signed CLA.

@slorber slorber merged commit f43be85 into facebook:main Aug 9, 2024
35 checks passed
@Gekd Gekd deleted the et-translation-fixes branch August 12, 2024 07:47
This was referenced Aug 30, 2024
Closed
Closed
Closed
@OATEF4313 OATEF4313 mentioned this pull request Sep 19, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Sep 19, 2024
Open
@OATEF4313 OATEF4313 mentioned this pull request Sep 20, 2024
Open
@qdraw qdraw mentioned this pull request Sep 21, 2024
Closed
@OATEF4313 OATEF4313 mentioned this pull request Sep 21, 2024
Open
@galopeian1 galopeian1 mentioned this pull request Sep 26, 2024
Open
This was referenced Sep 28, 2024
Closed
Closed
This was referenced Sep 29, 2024
Merged
Closed
Closed
This was referenced Oct 4, 2024
Open
Open
Open
@KaliforniaShell KaliforniaShell mentioned this pull request Oct 15, 2024
Merged
This was referenced Oct 19, 2024
Open
Open
Open
Open
Open
This was referenced Oct 20, 2024
Merged
Open
This was referenced Nov 5, 2024
Open
Open
Open
@Sec32fun32 Sec32fun32 mentioned this pull request Nov 7, 2024
Open
This was referenced Nov 10, 2024
Closed
Closed
This was referenced Nov 11, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirbard chirbard chirbard left review comments

@slorber slorber slorber requested changes

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gekd @facebook-github-bot @slorber @chirbard