docker: Only push latest tag when no others where specified #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, for the late reply; I just came back from PTO. Thanks a lot for your PR 👍 . I think it's correcting wrong behavior. I was able to reproduce this issue with https://github.com/rohankanojia-forks/fabric8-dmp-1495-reproducer . I think we should go ahead with fixing this. We can add a note in doc/changelog.md regarding the change in behavior. Would it be possible for you to move JibService related changes to a separate PR? Also, some tests for validating changes in RegistryService would be nice too :-) |
Signed-off-by: Martin Panzer <postremus1996@googlemail.com>
Postremus
changed the title
|
@rohanKanojia done |
rohanKanojia
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no way to only push the specified tags. Latest is always pushed, for docker and jib mode.
I changed both build modes, so they now behave as follows.
Jib however did not respect skipTag, which I also implemented.
This is a draft pr, since this changes established behaviour of the plugin, and I want feedback on it first.
This pr only handled docker mode, for jib changes, please see #1498.
closes #1495