Adding build options for the BuildImageConfiguration #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Katsuya Tomioka <katsuya@basistech.com>
This avoids corrupted log files. Fixes fabric8io#652.
AWS ECR key exchange closes fabric8io#637 Signed-off-by: Chas Honton <chas@apache.org>
Signed-off-by: Chas Honton <chas@apache.org>
The build options are propagated as query arguments to the REST request (https://docs.docker.com/engine/reference/api/docker_remote_api_v1.24/#/build-image-from-a-dockerfile). Signed-off-by: Robert Weiser <robert.weiser@elca.ch>
Current coverage is 47.39% (diff: 58.33%)@@ master #666 diff @@
==========================================
Files 113 113
Lines 5881 5891 +10
Methods 0 0
Messages 0 0
Branches 1020 1022 +2
==========================================
+ Hits 2786 2792 +6
- Misses 2850 2854 +4
Partials 245 245
|
Signed-off-by: Chas Honton <chas@apache.org>
Signed-off-by: Chas Honton <chas@apache.org>
Signed-off-by: Katsuya Tomioka <katsuya@basistech.com>
added ability to explicitly via configuration to create named volumes
via <volumes><volume> configuration.
Example config
```xml
<volumes>
<volume>
<name>Volume Name</name>
<driver>local</driver>
<driverOpts>
<driverOpt-key-name>driverOpt-value</driverOpt-key-name>
</driverOpts>
<labels>
<label-key>someValue</label-key>
<com-github-fabric8-dmp-sample-volume>
voluminous
</com-github-fabric8-dmp-sample-volume>
</labels>
</volume>
</volumes>
```
Added a new volume sample
Added a new goal volume-create
minor formatting / spelling correction for intro.md
Signed-off-by: Tom Burton <Tom.Burton@Outlook.com>
Signed-off-by: Tom Burton <Tom.Burton@Outlook.com>
fabric8io#664 (review) corrected spelling corrected ascii-doc + formatting code formatting Signed-off-by: Tom Burton <Tom.Burton@Outlook.com>
fabric8io#664 (review) corrected spelling corrected ascii-doc + formatting code formatting Signed-off-by: Tom Burton <Tom.Burton@Outlook.com>
This is a cleanup of PR fabric8io#664 with the following major points tackled: * Cleaned formatting * Removed unneeded classes and service method for listing and getting volumes. This is not needed now and probablu not in the future. * Fixed some Copy&Pase errors (like the default phase for 'volume-remove' which was the same as for 'volume-create' * Fixed tests. Please note, that *no service method* should be adapted to be "testable". Especially do not introduce a non-private method only for this purpose and test this method instead of the offiical API. Modern Mock frameworks can deal with the the problems which are tried to be solved with this. Otherwise the API gets dilulted, more complicated, more maintenance, more coupled. * Removed assert that do nothing. Tests can be still improved for the service but its fine for now, Next step is to add support for the PropertyHandler to allow configuration of the volumes also via properties.
PR merged! Thanks!
PR merged! Thanks!
Signed-off-by: Katsuya Tomioka <katsuya@basistech.com>
Signed-off-by: Katsuya Tomioka <katsuya@basistech.com>
Signed-off-by: Katsuya Tomioka <katsuya@basistech.com>
PR merged! Thanks!
PR merged! Thanks!
…ven-plugin into hwellmann-garbled-logs
This change is related to fabric8io#661 to make start / stop more symmetric - removing Java 8 methods - minor cosmetics
…oka/docker-maven-plugin into Katsuya-Tomioka-docker-load-support
- docs for docker.dockerArchive external property - removed unneed boolean tag - removed unused method
…port PR merged! Thanks!
…kerFileDir also set Signed-off-by: Laszlo Meszaros <lacienator@gmail.com>
Also streamlined the load image functionality. This includes the code from fabric8io#624 and fixes fabric8io#624
PR merged! Thanks!
PR merged! Thanks!
This is required to make unit tests predictable.
PR merged! Thanks!
PR merged! Thanks!
… into weiserr-master
- Updated changelog - Refactored to use BuildOptions instead of overly lengthy argument lists - Tuned documentation a bit
rhuss
reviewed
Jan 3, 2017
| @@ -66,7 +66,7 @@ public void buildImage(ImageConfiguration imageConfig, MojoParameters params, bo | |||
| dockerArchive, | |||
| getDockerfileName(buildConfig), | |||
| cleanupMode.isRemove(), | |||
| noCache, mergedBuildMap); | |||
| noCache, mergedBuildMap, buildConfig.getBuildOptions()); | |||
There was a problem hiding this comment.
The argument lists becomes quite lengthy now, so that I have refactored it to use a BuildOptions argument object. Makes it much nicer, too to merge the various options into a single place.
|
Thanks a lot ! Looks good to me, I made some minor changes (see next commit) and will merge it for the next release. |
|
[merge] |
|
Cheers! |
rgbj
pushed a commit
to rgbj/docker-maven-plugin
that referenced
this pull request
Jun 21, 2017
- Updated changelog - Refactored to use BuildOptions instead of overly lengthy argument lists - Tuned documentation a bit
rgbj
pushed a commit
to rgbj/docker-maven-plugin
that referenced
this pull request
Jun 21, 2017
PR merged! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes within this PullRequest allow adding arbitrary "simple" queryArguments to the Docker daemon build REST interface (https://docs.docker.com/engine/reference/api/docker_remote_api_v1.24/#/build-image-from-a-dockerfile).
For the full conversation please see #623.