Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assembly descriptors should be optional #66

Closed
tdiesler opened this issue Dec 8, 2014 · 4 comments
Closed

assembly descriptors should be optional #66

tdiesler opened this issue Dec 8, 2014 · 4 comments
Labels
bug
Milestone
0.11.2

Comments

@tdiesler
Copy link

tdiesler commented Dec 8, 2014

The target image may just want to set a few env entries or a different command

[ERROR] Failed to execute goal org.jolokia:docker-maven-plugin:0.10.4:build (build-docker-image) on project wildfly-camel-itests-openshift-domain: Error reading assembly: No assembly descriptors found. -> [Help 1]
@rhuss
Copy link
Collaborator

rhuss commented Dec 8, 2014

thx, will have a look ASAP.

@rhuss rhuss added this to the 0.10.6 milestone Dec 8, 2014
@rhuss rhuss added the bug label Dec 8, 2014
@jgangemi
Copy link
Collaborator

jgangemi commented Dec 8, 2014

this should be able to handled as part of #64 however i think it will required an explicit setting to indicate no assembly required b/c if you were ok w/ all the defaults, you wouldn't need to define an assembly block and would just need to make sure you had a file in the default directory (currently src/main/docker however that can also be changed).

@jgangemi jgangemi mentioned this issue Dec 8, 2014
Closed
@jgangemi
Copy link
Collaborator

it looks like i forget to do this w/ #64 but i just submitted a pull request for this.

@jgangemi jgangemi mentioned this issue Feb 19, 2015
Merged
@rhuss rhuss modified the milestones: 0.11.2, 0.11.0 Mar 1, 2015
@rhuss
Copy link
Collaborator

rhuss commented Mar 1, 2015

fixed in 0.11.2

@rhuss rhuss closed this as completed Mar 1, 2015
leusonmario pushed a commit to leusonmario/docker-maven-plugin that referenced this issue Aug 18, 2018
@davidxia
Fix NPE for newly initialized git repo
1ed3dae 
Fixes fabric8io#66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.11.2
Development

No branches or pull requests
3 participants
@rhuss @tdiesler @jgangemi