Add option for regenerating certificates after starting Docker Machine #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1019 +/- ##
============================================
- Coverage 51.82% 51.71% -0.11%
Complexity 1367 1367
============================================
Files 147 147
Lines 7460 7475 +15
Branches 1132 1134 +2
============================================
Hits 3866 3866
- Misses 3229 3244 +15
Partials 365 365
|
If using Docker Machine with the AWS EC2 driver, the remote host will have a new IP address every time it is started up again. This causes the Docker Maven plug-in to fail with an error about certificates being invalid when starting up the machine automatically. Add an option to automatically regenerate the certificates for the new IP address after startup. Setting this option to true will allow Docker Machines running in AWS EC2 to be automatically started up into a usable state by the Docker Maven plug-in. Signed-off-by: Markus Hallmann <markhalm256@gmail.com>
|
Would be possible to have this merged? The code coverage results are mainly due to Docker Machine code already not being covered, and adding coverage for anything new related to Docker Machine is challenging without any existing testing setup. |
rhuss
approved these changes
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using Docker Machine with the AWS EC2 driver, the remote host will have a new IP address every time it is started up again. This causes the Docker Maven plug-in to fail with an error about certificates being invalid when starting up the machine automatically. Add an option to automatically regenerate the certificates for the new IP address after startup. Setting this option to true will allow Docker Machines running in AWS EC2 to be automatically started up into a usable state by the Docker Maven plug-in. (Without this option, such automatically started machines will fail the Maven Docker plug-in invocation complaining about certificates being invalid as the existing certificates are associated with the old IP address)
The changes have been tested with the option both on and off, and are working as expected. Also the documentation has been updated to mention the new option and when it is useful.