fix snapshot url for multicam plugin #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multicam plugin now supports defining a snapshot url.
This means we should try to read this user defined url instead of deriving the url from the stream url.
I changed it in a way to first try to read the "snapshot" value and use as a snapshot url. Should this value be empty it will default to the old method.
I had an issues with an ESP32cam since the url for the snapshot is not the same format as for a mjpg streamer cam. I'm simply not able to use the cam with this plugin since it ignores the snapshot url defined in the mulitcam plugin.
This will also be fixed with this PR.
Andi