Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds pre-commit-hooks #361

Merged
merged 3 commits into from
Jun 7, 2021
Merged

Conversation

FranciscodeMaussion
Copy link
Contributor

Hi there I would like to add some pre-commit-hooks to get a more maintainable code base.

Here I added(some of them are self explanatory):

  • trailing-whitespace
  • end-of-file-fixer
  • check-yaml
  • check-merge-conflict
  • isort: sorts imports alphabetically, and automatically separated into sections and by type. github repo
  • black: code formatter that follows python pep 8 and pythonic way. github repo
  • flake8: wrapper around PyFlakes(checks for errors), pycodestyle(again pep8 check), Ned Batchelder's McCabe script(don't really know this one)

My idea is to start helping here ASAP. but I think this is a good step.

@FranciscodeMaussion FranciscodeMaussion changed the title Add pre-commit-hooks Adds pre-commit-hooks Jun 4, 2021
@FranciscodeMaussion
Copy link
Contributor Author

pip install pre-commit
pre-commit install

and then trying to commit sth will do the magic

@giloser giloser merged commit 7d4cbc8 into fabianonline:master Jun 7, 2021
@giloser
Copy link
Collaborator

giloser commented Jun 7, 2021

thanks I'll try that as soon as I can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants