Fix F3D build when added as a subproject #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok but why should F3D support that ? |
|
If we want to support that we need to test it |
Codecov Report
@@ Coverage Diff @@
## master #899 +/- ##
==========================================
+ Coverage 96.09% 96.12% +0.03%
==========================================
Files 113 113
Lines 6472 6533 +61
==========================================
+ Hits 6219 6280 +61
Misses 253 253 see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mwestphal
approved these changes
Jul 7, 2023
spianmo
added a commit
to spianmo/f3d
that referenced
this pull request
Jul 11, 2023
This reverts commit 3f713f3
spianmo
added a commit
to spianmo/f3d
that referenced
this pull request
Jul 11, 2023
This reverts commit 3f713f3
mwestphal
pushed a commit
that referenced
this pull request
Feb 10, 2024
mwestphalnew
pushed a commit
to mwestphalnew/f3d
that referenced
this pull request
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If F3D is added as a subproject using
add_subdirectory, many things are not working because of the usage ofCMAKE_SOURCE_DIRwhich refer to the top level directory. Let's useF3D_SOURCE_DIRinstead.FYI the variable
F3D_SOURCE_DIRis defined automatically when callingproject(F3D)Since CMake 3.21 there is a PROJECT_IS_TOP_LEVEL. We can use that too for the plugins.