Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shortcut to rotate camera #863

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Add shortcut to rotate camera #863

merged 1 commit into from
Jul 7, 2023

Conversation

lknknm
Copy link
Contributor

@lknknm lknknm commented Jun 20, 2023 •
edited
Loading

Feature to add shortcuts to rotate the camera view (Front, Right, Top).
This will implement the following set of shortcuts to manipulate camera views:

  • 1, 3 and 7: Axis movement (Front, Right, Top View);
  • 9: Front isometric view;

@lknknm lknknm marked this pull request as ready for review June 21, 2023 15:54
@lknknm lknknm requested a review from mwestphal June 21, 2023 16:01
@mwestphal
Copy link
Contributor

@lknknm you need to rebase on master and fix potential conflicts, do not hesitate if you need help with that

@lknknm lknknm force-pushed the add_camera_shortcuts branch from ad4e5db to 829bd15 Compare June 30, 2023 17:52
Meakk
Meakk reviewed Jul 1, 2023
View reviewed changes
Copy link
Member

@Meakk Meakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can find the doc here: https://vtk.org/doc/nightly/html/classvtkMatrix3x3.html

library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
@lknknm lknknm mentioned this pull request Jul 1, 2023
Open
@codecov
Copy link

codecov bot commented Jul 4, 2023 •
edited
Loading

Codecov Report

Merging #863 (470c5e8) into master (e3d0dd3) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 470c5e8 differs from pull request most recent head fd4ac52. Consider uploading reports for the commit fd4ac52 to get more accurate results

@@            Coverage Diff             @@
##           master     #863      +/-   ##
==========================================
+ Coverage   96.07%   96.13%   +0.05%     
==========================================
  Files         113      113              
  Lines        6454     6538      +84     
==========================================
+ Hits         6201     6285      +84     
  Misses        253      253
Impacted Files Coverage Δ
library/src/interactor.cxx 100.00% <ø> (ø)
library/VTKExtensions/Rendering/vtkF3DRenderer.cxx 99.67% <100.00%> (+<0.01%) ⬆️
library/src/interactor_impl.cxx 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Meakk Meakk mentioned this pull request Jul 5, 2023
Closed
Meakk
Meakk reviewed Jul 5, 2023
View reviewed changes
library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
library/src/interactor_impl.cxx Show resolved Hide resolved
@Meakk Meakk linked an issue Jul 5, 2023 that may be closed by this pull request
Add View options to the viewport for orthographic views. #896
Closed
snoyer
snoyer reviewed Jul 5, 2023
View reviewed changes
Copy link
Contributor

@snoyer snoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe my suggestion of using a transform was a bit over-complicated...

library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
library/src/interactor_impl.cxx Outdated Show resolved Hide resolved
@lknknm lknknm force-pushed the add_camera_shortcuts branch from 470c5e8 to 658af09 Compare July 5, 2023 19:02
@lknknm lknknm force-pushed the add_camera_shortcuts branch from 658af09 to fd4ac52 Compare July 6, 2023 15:13
mwestphal
mwestphal approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still looks good

@Meakk Meakk merged commit 7541102 into f3d-app:master Jul 7, 2023
mwestphal pushed a commit that referenced this pull request Feb 10, 2024
@lknknm
Add shortcut to rotate camera (#863)
be2fde1
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
@lknknm
Add shortcut to rotate camera (f3d-app#863)
1e96949
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyer snoyer snoyer left review comments

@Meakk Meakk Meakk approved these changes

@mwestphal mwestphal mwestphal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add View options to the viewport for orthographic views.
4 participants
@lknknm @mwestphal @snoyer @Meakk