You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

What does that entail for the data buffer exposed through unsigned char* image::getData()?

For example, in the case of a float-based image would getData() return the raw encoded floating point values as bytes?

Nevermind, I have another idea to refactor this class.

What does that entail for the data buffer exposed through unsigned char* image::getData()?

For example, in the case of a float-based image would getData() return the raw encoded floating point values as bytes?

Just to answer the question. Usually, when you have a buffer of an unknown type, you can just use a buffer of bytes and reinterpret_cast the buffer later. You have to be careful about the endianness though.

What does that entail for the data buffer exposed through unsigned char* image::getData()?
For example, in the case of a float-based image would getData() return the raw encoded floating point values as bytes?

Just to answer the question. Usually, when you have a buffer of an unknown type, you can just use a buffer of bytes and reinterpret_cast the buffer later. You have to be careful about the endianness though.

Alright so if the bindings expose this raw data too, multiplying the length by the new channel width here and here should do.

You're right! Nice catch :)

@mwestphal I've modified the public API without taking care of backward compatibility. Do you think it's fine?

I do not see any non retro compat changes, looks fine

I removed some setters to put them in a dedicated constructor.

Ideally they should be deprecated, if possible by keeping the feature with a warning, if not, by keeping the method but erroring out.

Not saying this will impact a lot of people but we need to think of a process that works for the future of F3D. I know very well the system in VTK, maybe we need something similar ? I can create an issue about it if you want.

Codecov Report

Merging #858 (a84339d) into master (ca76333) will decrease coverage by 0.25%.
The diff coverage is 96.05%.

❗ Current head a84339d differs from pull request most recent head d766c80. Consider uploading reports for the commit d766c80 to get more accurate results

@@            Coverage Diff             @@
##           master     #858      +/-   ##
==========================================
- Coverage   96.06%   95.81%   -0.25%     
==========================================
  Files         113      115       +2     
  Lines        6551     6643      +92     
==========================================
+ Hits         6293     6365      +72     
- Misses        258      278      +20     

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more