Add MatCap texture option #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #851 +/- ##
==========================================
+ Coverage 96.14% 96.16% +0.01%
==========================================
Files 111 111
Lines 6335 6366 +31
==========================================
+ Hits 6091 6122 +31
Misses 244 244
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
snoyer
reviewed
Jun 8, 2023
mwestphal
reviewed
Jun 8, 2023
mwestphal
reviewed
Jun 8, 2023
mwestphal
reviewed
Jun 8, 2023
mwestphal
reviewed
Jun 8, 2023
mwestphal
reviewed
Jun 8, 2023
mwestphal
reviewed
Jun 8, 2023
mwestphal
reviewed
Jun 8, 2023
|
please improve descr and mention the bugfix |
mwestphal
approved these changes
Jun 8, 2023
mwestphal
pushed a commit
that referenced
this pull request
Feb 10, 2024
mwestphalnew
pushed a commit
to mwestphalnew/f3d
that referenced
this pull request
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #811
Add a new shading model based on MatCap textures.
These textures encode everything: ambient, diffuse, specular and baked lighting.
When the texture is given throught
--texture-matcapoption, all other materials and lights are ignored.For example, the image above is generated using the following texture:
Usually the textures will be squared and should look like a sphere touching the edge of the texture.
This PR also fixes an issue when textures given by the user have a depth of 16 or 32 bits per channel.