Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with the drop zone when no mapper is set #829

Merged
merged 1 commit into from
May 26, 2023

Conversation

mwestphal
Copy link
Contributor

When no mapper is set vtkActor2D is erroring in the default impl of rendering methods. Override them to avoid that.

@mwestphal mwestphal marked this pull request as ready for review May 26, 2023 06:19
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #829 (810192a) into master (54216f3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 810192a differs from pull request most recent head 2f5abff. Consider uploading reports for the commit 2f5abff to get more accurate results

@@           Coverage Diff           @@
##           master     #829   +/-   ##
=======================================
  Coverage   96.19%   96.19%           
=======================================
  Files         111      111           
  Lines        6205     6207    +2     
=======================================
+ Hits         5969     5971    +2     
  Misses        236      236           
Impacted Files Coverage Δ
...rary/VTKExtensions/Rendering/vtkF3DDropZoneActor.h 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

When no mapper is set vtkActor2D is erroring in the default
impl of rendering methods. Override them to avoid that.
@mwestphal mwestphal force-pushed the fix_drop_zone_error branch from 810192a to 2f5abff Compare May 26, 2023 06:48
@mwestphal mwestphal merged commit 877ccd6 into f3d-app:master May 26, 2023
mwestphal added a commit that referenced this pull request Feb 10, 2024
When no mapper is set vtkActor2D is erroring in the default
impl of rendering methods. Override them to avoid that.
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
When no mapper is set vtkActor2D is erroring in the default
impl of rendering methods. Override them to avoid that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants