-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add soname to shared library #822
Conversation
Update CMakelists to add soname to shared library using VERSION ${F3D_VERSION} and SOVERSION ${F3D_MAJOR_VERSION}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Wdyt @mwestphal?
Ubuntu failures can probably be fixed by adding libbsd-dev to the image, or using apt to install this during the CI build |
Actually caused by a slight change in our docker setup, will be fixed soon |
Codecov Report
@@ Coverage Diff @@
## master #822 +/- ##
==========================================
+ Coverage 96.07% 96.13% +0.05%
==========================================
Files 109 109
Lines 6173 6110 -63
==========================================
- Hits 5931 5874 -57
+ Misses 242 236 -6 see 40 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Ill need to check and understand how sonames work |
Thanks for the links ! |
Note that I don't see the library with the version suffix or the symlinks in the CI logs here: https://github.com/f3d-app/f3d/actions/runs/5037504197/jobs/9034730385?pr=822#step:14:123 |
Contents of library directory (Java not built): |
Thank you. It looks like it is what we are expecting 👍 |
@mzf-guest You may want to take a look at this. |
Okay for you @Meakk ? |
Yes |
* Add soname to shared library Update CMakelists to add soname to shared library using VERSION ${F3D_MAJOR_VERSION}.${F3D_MINOR_VERSION} and SOVERSION ${F3D_MAJOR_VERSION}
* Add soname to shared library Update CMakelists to add soname to shared library using VERSION ${F3D_MAJOR_VERSION}.${F3D_MINOR_VERSION} and SOVERSION ${F3D_MAJOR_VERSION}
Update CMakelists to add soname to shared library
using VERSION ${F3D_VERSION} and SOVERSION ${F3D_MAJOR_VERSION}
#821