Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add soname to shared library #822

Merged
merged 2 commits into from
May 23, 2023
Merged

Add soname to shared library #822

merged 2 commits into from
May 23, 2023

Conversation

bkmgit
Copy link
Contributor

@bkmgit bkmgit commented May 21, 2023

Update CMakelists to add soname to shared library
using VERSION ${F3D_VERSION} and SOVERSION ${F3D_MAJOR_VERSION}

#821

Update CMakelists to add soname to shared library
using  VERSION ${F3D_VERSION} and SOVERSION ${F3D_MAJOR_VERSION}
Copy link
Member

@Meakk Meakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Wdyt @mwestphal?

@bkmgit
Copy link
Contributor Author

bkmgit commented May 21, 2023

Ubuntu failures can probably be fixed by adding libbsd-dev to the image, or using apt to install this during the CI build

@mwestphal
Copy link
Contributor

Actually caused by a slight change in our docker setup, will be fixed soon

@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Merging #822 (d637f49) into master (f943d09) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #822      +/-   ##
==========================================
+ Coverage   96.07%   96.13%   +0.05%     
==========================================
  Files         109      109              
  Lines        6173     6110      -63     
==========================================
- Hits         5931     5874      -57     
+ Misses        242      236       -6     

see 40 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mwestphal
Copy link
Contributor

Ill need to check and understand how sonames work

@bkmgit
Copy link
Contributor Author

bkmgit commented May 22, 2023 via email

@mwestphal
Copy link
Contributor

Thanks for the links !

@Meakk
Copy link
Member

Meakk commented May 22, 2023

Note that I don't see the library with the version suffix or the symlinks in the CI logs here: https://github.com/f3d-app/f3d/actions/runs/5037504197/jobs/9034730385?pr=822#step:14:123
Please double check it's properly generated on your side.

@bkmgit
Copy link
Contributor Author

bkmgit commented May 22, 2023

Contents of library directory (Java not built):
lib]$ tree
.
├── f3d.cpython-311-x86_64-linux-gnu.so
├── libf3d-plugin-exodus.a
├── libf3d-plugin-native.a
├── libf3d.so -> libf3d.so.2
├── libf3d.so.2 -> libf3d.so.2.0.0
├── libf3d.so.2.0.0
├── libVTKExtensionsApplicative.a
├── libVTKExtensionsCore.a
├── libVTKExtensionsReaders.a
└── libVTKExtensionsRendering.a

@Meakk
Copy link
Member

Meakk commented May 22, 2023

Thank you. It looks like it is what we are expecting 👍

library/CMakeLists.txt Outdated Show resolved Hide resolved
@mwestphal
Copy link
Contributor

@mzf-guest You may want to take a look at this.

@mwestphal mwestphal requested a review from Meakk May 23, 2023 05:44
@mwestphal
Copy link
Contributor

Okay for you @Meakk ?

@Meakk
Copy link
Member

Meakk commented May 23, 2023

Yes

@mwestphal mwestphal merged commit 20bca75 into f3d-app:master May 23, 2023
@mwestphal mwestphal mentioned this pull request May 23, 2023
mwestphal pushed a commit that referenced this pull request Feb 10, 2024
* Add soname to shared library

Update CMakelists to add soname to shared library
using  VERSION ${F3D_MAJOR_VERSION}.${F3D_MINOR_VERSION} and SOVERSION ${F3D_MAJOR_VERSION}
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
* Add soname to shared library

Update CMakelists to add soname to shared library
using  VERSION ${F3D_MAJOR_VERSION}.${F3D_MINOR_VERSION} and SOVERSION ${F3D_MAJOR_VERSION}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants