Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated FormType for Symfony 3. #14

Merged
merged 4 commits into from
Apr 26, 2016
Merged

Conversation

iisisrael
Copy link
Contributor

Removed the getName() method, updated the parent name to the fully qualified class, and changed setDefaultOptions() to configureOptions().

The parent class name is in the format of Namespace\ClassName instead of ClassName::class for < PHP 5.5.

@iisisrael
Copy link
Contributor Author

All tests pass when symfony-test requirement is updated to this version.

@peschee
Copy link

peschee commented Apr 26, 2016

Any updates on this PR?

@eymengunay eymengunay merged commit f3e99a7 into eymengunay:master Apr 26, 2016
@eymengunay
Copy link
Owner

Oops, sorry about that! I have completely forgotten about this pr.

I've merged both this and eymengunay/symfony-test#2

Thank you @iisisrael and @peschee

@Falc Falc mentioned this pull request Apr 27, 2016
@peschee
Copy link

peschee commented Apr 28, 2016

@eymengunay Did you tag from master? I still have setDefaultOptions instead of configureOptions in HoneypotType.php

https://github.com/eymengunay/EoHoneypotBundle/blob/1.0.1/Form/Type/HoneypotType.php

@eymengunay
Copy link
Owner

@peschee, No I've tagged from c17675f, the last commit before symfony 3 changes were introduced.

@peschee
Copy link

peschee commented Apr 28, 2016

Ah yes, all good, saw that now. Thanks.

@peschee peschee mentioned this pull request Apr 28, 2016
@iisisrael iisisrael deleted the patch-13 branch January 2, 2017 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants