-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: create an action to release to npm automatically when a new git tag is created #14
Conversation
@wikiwong we need a |
@mhmd-azeez I've added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to me. The only thing I will caveat this with is that we may not always be publishing to NPM immediately once we tag for release. @chrisdickinson outlined a similar process we may want to use here: https://github.com/extism/python-sdk#release-workflow
I think this is ok for now so approving, but @chrisdickinson feel free to veto if you think we should wait
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally I'd like to follow the tag -> draft release, publish release -> publish to package managers flow that @wikiwong mentioned but I don't think it's a blocker here – I'd be happy to take a look at that in a subsequent PR. (Deno's webhooks make following this flow a little tricky since they assume that "tag publish" == "release".)
I did add some suggestions aimed at letting us use the same vX.X.X
tagging scheme as other repos, though!
Co-authored-by: Chris Dickinson <chris@neversaw.us>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think we can land this and then iterate on the release flow in a separate PR.
Fixes #12
For Deno, we just need to submit the repo here: https://deno.com/add_module, I don't have the right permissions to do it
Note: the git tags must no longer have the
v
prefix, let me know if this is a deal breaker. Example:1.0.0-rc2