-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-export config-plugins from expo package and update docs #18855
Conversation
ENG-6059 Explain for third party library authors how to add a config plugin dependency to a library
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
06dacf6
to
e02ea28
Compare
The following packages currently use private APIs from
I think we should fix these in a follow-up PR. @EvanBacon - should we be exposing |
fbc57be
to
472deb0
Compare
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
@rnmapbox/maps also uses some private APIs which are currently not exported with the new style: import {
mergeContents,
removeGeneratedContents,
} from '@expo/config-plugins/build/utils/generateCode'; Do you already have any followup issue on this topic? |
@KiwiKilian - you should be able to copy and paste those functions out into the mapbox library, these aren't intended to be public APIs. ideally we want to come up with a better API for interacting with podfile |
Official plugins also use it. https://github.com/expo/config-plugins/blob/ed020d236b8fa4a810adf90a9773d9a2fba36fd4/packages/react-native-pdf/src/withPdf.ts#L7 Maybe expose it as |
Why
thecodedrift/expo-community-flipper#16
Fixes ENG-6059
Checklist