Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update blis #6198

Merged
merged 4 commits into from
Oct 5, 2020
Merged

update blis #6198

merged 4 commits into from
Oct 5, 2020

Conversation

svlandeg
Copy link
Member

@svlandeg svlandeg commented Oct 4, 2020

Description

Allow higher pin of blis to match that of Thinc + few typo fixes + bump to "3.0.0a34"

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added the v3.0 Related to v3.0 label Oct 4, 2020
@explosion-bot
Copy link
Collaborator

Hi @svlandeg, thanks for your pull request! 👍 It looks like you haven't filled in the spaCy Contributor Agreement (SCA) yet. The agreement ensures that we can use your contribution across the project. Once you've filled in the template, put it in the .github/contributors directory and add it to this pull request. If your pull request targets a branch that's not master, for example develop, make sure to submit the Contributor Agreement to the master branch. Thanks a lot!

If you've already included the Contributor Agreement in your pull request above, you can ignore this message.

@adrianeboyd
Copy link
Contributor

setup.cfg and pyproject.toml need to be modified, too. (I thought we had a test that caught when these were out-of-sync?)

I have an update to setup.py for blis that we may or may not want to publish as 0.7.2 before the final v3 is released that stops you with a warning before compiling if you have an older version of pip, since you rarely want to compile it yourself.

@svlandeg
Copy link
Member Author

svlandeg commented Oct 5, 2020

setup.cfg and pyproject.toml need to be modified, too. (I thought we had a test that caught when these were out-of-sync?)

hm, good point, why is that test not catching this? I'll have a look.

@svlandeg
Copy link
Member Author

svlandeg commented Oct 5, 2020

Ah, that test does fail locally. Whoops.

ines
ines reviewed Oct 5, 2020
View reviewed changes
spacy/pipeline/morphologizer.pyx
@@ -210,7 +210,7 @@ class Morphologizer(Tagger):

examples (Iterable[Examples]): The batch of examples.
scores: Scores representing the model's predictions.
RETUTNRS (Tuple[float, float]): The loss and the gradient.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alt Text

@honnibal honnibal merged commit f4f49f5 into explosion:develop Oct 5, 2020
@svlandeg svlandeg deleted the feature/update-blis branch October 5, 2020 12:59
@rmax rmax mentioned this pull request Oct 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ines ines ines left review comments

Assignees
No one assigned
Labels
v3.0 Related to v3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@svlandeg @explosion-bot @adrianeboyd @ines @honnibal