-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language.replace_listeners
: Pass the replaced listener and the tok2vec
pipe to the callback
#12785
Merged
svlandeg
merged 7 commits into
explosion:develop
from
shadeMe:feature/replace-listener-metadata
Jul 5, 2023
Merged
Language.replace_listeners
: Pass the replaced listener and the tok2vec
pipe to the callback
#12785
svlandeg
merged 7 commits into
explosion:develop
from
shadeMe:feature/replace-listener-metadata
Jul 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2vec` pipe to the callback
shadeMe
added
enhancement
Feature requests and improvements
feat / tok2vec
Feature: Token-to-vector layer and pretraining
feat / transformer
Feature: Transformer
v3.7
Related to v3.7
labels
Jul 4, 2023
3 tasks
danieldk
reviewed
Jul 4, 2023
svlandeg
reviewed
Jul 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There's nowhere in the public docs that we need to update, right?
No, I don't believe so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Feature requests and improvements
feat / tok2vec
Feature: Token-to-vector layer and pretraining
feat / transformer
Feature: Transformer
v3.7
Related to v3.7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to this PR,
Language.replace_listeners
only passed the copiedtok2vec
/transformer
model to thereplace_listener
callback. This worked forspacy-transformers
as the library only uses a singleTransformerListener
class, i.e., the replacement model was always the same. However,spacy-curated-transformers
introduces the concept of different listener classes for downstream components. So, the replacement process needs to provide extra information about the listener model being replaced to correctly select the target model.This PR adds support for such situations by passing the following extra arguments to the
replace_listener
callback: the replaced listener instance and thetok2vec
pipe whose model is copied into the downstream component. These argumentss are only passed when the callback accepts them, so the implementation is backwards-compatible with the callback used inspacy-transformers
.Types of change
Enhancement
Checklist